See summary. Reproducible: Always Steps to Reproduce:
Created attachment 145589 [details, diff] vlc-0.9.0_qt-4.4-split.patch
Thanks, but I cant apply that patch like that: qt >=4.2.0 is still needed and with these changes we lose that. Any why is there a slot dep for qt-gui ? this seems superfluous to me.
(In reply to comment #2) > Thanks, but I cant apply that patch like that: qt >=4.2.0 is still needed and > with these changes we lose that. Then change it to >=x11-libs/qt-4.3.0. I have been told by Ingmar not to use qt4_min_version, which is why I changed it. Since we don't want to pull in x11-libs/qt-4.4 either (might get removed in the near future, hopefully) and because there is no <x11-libs/qt-4.3.0 in the tree anymore, I thought this might be the best solution. Still unsure, though. > Any why is there a slot dep for qt-gui ? this seems superfluous to me. > The <x11-libs/qt-4.4_alpha:4 needs the slot anyway (if used like this) and since it doesn't hurt I added it for qt-gui, too (was using slot dependencies anyway). Is is of course not needed currently, since there is only one qt-gui ebuild.
(In reply to comment #3) > (In reply to comment #2) > > Thanks, but I cant apply that patch like that: qt >=4.2.0 is still needed and > > with these changes we lose that. > Then change it to >=x11-libs/qt-4.3.0. I have been told by Ingmar not to use > qt4_min_version, which is why I changed it. Since we don't want to pull in > x11-libs/qt-4.4 either (might get removed in the near future, hopefully) and > because there is no <x11-libs/qt-4.3.0 in the tree anymore, I thought this > might be the best solution. Still unsure, though. Having correct deps is not about what is currently in the tree, its about what has been at some point in the tree. If we dont specify the minimum required version, people not having upgraded qt since a year or so can experience failures. Anyway, I've just applied a modified version of the patch, thanks !
