Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 212452 - x11-apps/xdm-1.1.6-r1 freezes after trying to log in, also breaks C-A-F1 / C-A-B to break out of X
Summary: x11-apps/xdm-1.1.6-r1 freezes after trying to log in, also breaks C-A-F1 / C-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High blocker (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-06 00:38 UTC by Harald van Dijk (RETIRED)
Modified: 2009-05-10 21:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xdm-pam-crash.patch (xdm-pam-crash.patch,543 bytes, patch)
2008-03-06 00:44 UTC, Harald van Dijk (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harald van Dijk (RETIRED) gentoo-dev 2008-03-06 00:38:13 UTC
x11-apps/xdm-1.1.6-r1 adds support for pambase. /etc/pam.d/xdm is now different, and one of the things that's different, is that now pam_lastlog.so gets loaded. xdm can't handle pam_lastlog.so, because it sends a message after xdm expects to receive no more messages. And by "can't handle" I mean it access and modifies freed memory, and in my case, this happens to crash in various ways, sometimes taking X with it (leaving me with a working console), sometimes freezing X. When X freezes, it forces me to do an unclean shutdown. Nothing else works. I can't get out of X, I can't take X down, I can't do anything at all but turn off the power.

I will attach a patch shortly.
Comment 1 Harald van Dijk (RETIRED) gentoo-dev 2008-03-06 00:44:09 UTC
Created attachment 145395 [details, diff]
xdm-pam-crash.patch

The fact that this patch allows me to log in without problems should tell you pretty much everything. After XtDestroyWidget (toplevel) is called, pamconv will be called again with a message containing the last login time. Since login is no longer usable, I've made pamconv simply return an error code. I don't know what the most appropriate behaviour would be, and if returning immediately is the most appropriate, I don't know which status should be returned.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2008-03-06 00:52:18 UTC
/me starts wondering what did most people test

Thanks Harald, I'll package.mask the new xdm until this is fixed.
Markus I suppose this is what you hit too.
Comment 3 Markus Dittrich (RETIRED) gentoo-dev 2008-03-06 10:38:47 UTC
Hi Diego,

That sounds very much like my problem, just that in my case PAX
detected the illegal access and killed xdm right away.

Thanks,
Markus
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2008-03-09 05:39:54 UTC
I'm bumping xdm to 1.1.7 without the pambase patches, so you'll need a revbump to that whenever you get this fixed.
Comment 5 Rémi Cardona (RETIRED) gentoo-dev 2009-05-06 14:58:08 UTC
ping here, what's the status?

Thanks
Comment 6 Rémi Cardona (RETIRED) gentoo-dev 2009-05-10 21:40:02 UTC
I'll assume this bug is now fixed. If not, please don't hesitate to reopen.

Thanks
Comment 7 Harald van Dijk (RETIRED) gentoo-dev 2009-05-10 21:56:32 UTC
While I'm not aware of a fix for this bug, the trigger for it has been removed and it doesn't look like it's coming back, so I'm fine with this being closed. (Sorry for not responding sooner.)