Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 212330 - [PATCH] app-portage/elogv enhancement
Summary: [PATCH] app-portage/elogv enhancement
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Christian Faulhammer (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-03-04 23:24 UTC by Michał Kiedrowicz
Modified: 2008-03-06 11:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
elogv patch (elogv-colors.diff,3.29 KB, patch)
2008-03-04 23:25 UTC, Michał Kiedrowicz
Details | Diff
elogv-tags.patch (elogv-tags.patch,3.07 KB, text/plain)
2008-03-05 13:48 UTC, Luca Marturana
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Kiedrowicz 2008-03-04 23:24:58 UTC
Hi, I modified elogv slightly so that each package in the file list has a mark indicating highest elog class (e.g. to quickly find error messages). I emailed author two weeks ago, but I didn't get any response (possibly my mail has been treated as spam). Include it in portage if You find it useful.

Reproducible: Always
Comment 1 Michał Kiedrowicz 2008-03-04 23:25:58 UTC
Created attachment 145313 [details, diff]
elogv patch
Comment 2 Christian Faulhammer (RETIRED) gentoo-dev 2008-03-05 07:03:03 UTC
Will have a deeper look the next days.  Thanks in advance anyway.
Comment 3 Luca Marturana 2008-03-05 13:48:31 UTC
Created attachment 145350 [details]
elogv-tags.patch

Hi, I've already answered your email on 29 feb. Anyway I liked much the idea, I've just changed two things:

1) the star is displayed in bold
2) I've modified the get_class method to be more compact and, I think, faster.

There is my version attached here, I will apply this on the svn version soon. It will be out on the next major release 0.7.

Regards, Luca
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2008-03-05 14:30:50 UTC
(In reply to comment #3)
> There is my version attached here, I will apply this on the svn version soon.
> It will be out on the next major release 0.7.

 Any date yet?  I will go stable elogv soon (because of the annoying bugs still present in the current stable version) anyway.

So I will not apply your patch, Michał, as upstream is aware and active.
Comment 5 Michał Kiedrowicz 2008-03-05 15:30:57 UTC
(In reply to comment #3)
> Hi, I've already answered your email on 29 feb. 
Sorry, but I haven't got it.

> Anyway I liked much the idea,
Great :-).

> I've just changed two things:
> 
> 1) the star is displayed in bold
> 2) I've modified the get_class method to be more compact and, I think, faster.
> 

Yeah, looks better. However, I have 2 questions (as I've stated I'm a python newbie):
1. Shouldn't f be closed after f.read()?
2. I've searched manuals regarding elog and einfo and I found elog more severe (it's logged by default and einfo isn't), so shouldn't elog be higher than einfo?

(In reply to comment #4)
> So I will not apply your patch, Michał, as upstream is aware and active.
> 

It's even better :-).
Comment 6 Christian Faulhammer (RETIRED) gentoo-dev 2008-03-05 17:47:43 UTC
(In reply to comment #5)
> 2. I've searched manuals regarding elog and einfo and I found elog more severe
> (it's logged by default and einfo isn't), so shouldn't elog be higher than
> einfo?

 Yes, it is.
Comment 7 Luca Marturana 2008-03-06 11:44:39 UTC
(In reply to comment #4)
>  Any date yet?  I will go stable elogv soon (because of the annoying bugs still
> present in the current stable version) anyway.

No, I want to do other things and tests before releasing a new major version, not so far though. For now the most stable is the latest 0.6.*
Usually I correct bugs with a minor version (for ex 0.6.*), released immediately, and add new features in a major version (for ex 0.7).

>(In reply to comment #5)
>
> Yeah, looks better. However, I have 2 questions (as I've stated I'm a python
> newbie):
> 1. Shouldn't f be closed after f.read()?
> 2. I've searched manuals regarding elog and einfo and I found elog more severe
> (it's logged by default and einfo isn't), so shouldn't elog be higher than
> einfo?
> 

1. I don't know if it's necessary in this case, anyway I've added f.close() too.
2. Ok, star tags will be displayed with this alarm level scale then: error, warn, log, info.

The svn trunk is now updated with all these notes. Thank you for the help. ;)