Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 211694 - [gnome-experimental] wrong deps for gnome-base/gvfs gphoto2 USE flag
Summary: [gnome-experimental] wrong deps for gnome-base/gvfs gphoto2 USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-28 06:27 UTC by Priit Laes (IRC: plaes)
Modified: 2008-03-16 08:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fixed dependencies (gvfs-0.1.11.ebuild,1.21 KB, text/plain)
2008-03-09 00:34 UTC, Andrea Innocenti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Priit Laes (IRC: plaes) 2008-02-28 06:27:54 UTC
The dependency should be media-libs/libgphoto2 not media-gfx/gphoto2

Although I wasn't able to test it functionality wise, compile without media-gfx/gphoto2 works as gphoto2 backend is enabled.
Comment 1 Andrea Innocenti 2008-03-09 00:34:33 UTC
Created attachment 145615 [details]
fixed dependencies

changed dependecies:
I require dev-libs/libcdio-0.79 and media-gfx/gphoto2-2.4.0 for build it correctly . media-libs/libgphoto2 is a dependency of gphoto2 but I didn't try to build gvfs without gphoto2.
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2008-03-12 11:00:08 UTC
Andrea, a couple things :

1) Please attach patches instead of full ebuilds, it's easier for us to review your changes.

2) You changed a whole lot of things that were perfectly fine in the ebuild and that will break with your version.

For instance, you force the glib version to 2.15.6 for no reason at all, glib versions are supposed to be forward compatible.

And for a bunch of similar reasons, your changes are wrong. Dependencies should not be based on what is available in portage but what the configure script says. Sorry to sound so blunt :)

Anyway, fixed in overlay, configure.ac says only libgphoto2 is needed.
Comment 3 Andrea Innocenti 2008-03-16 00:48:44 UTC
Unbelievable, I changed a few lines and I screwed up everything! :(
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2008-03-16 08:32:23 UTC
Don't sweat it, ebuilds are not as simple as they seem ;) That's also why we request patches rather than plain ebuilds. It makes reviewing easier for us, but also for you.

Thanks for trying anyway :)