Using the stage4 target with catalyst-2.0.6_pre6 always runs the empty function, even if that key wasn't defined. Looks like this was introduced to the svn trunk in r1299. I'll attach a patch that just pushes in the extra tabs required. Reproducible: Always Steps to Reproduce: 1. Create stage4 spec file without stage4/empty 2. Run catalyst. 3. Actual Results: --- Running action sequence: empty !!! catalyst: Error encountered during run of target stage4 Catalyst aborting.... Traceback (most recent call last): File "/usr/lib64/catalyst/catalyst", line 396, in ? build_target(addlargs, targetmap) File "/usr/lib64/catalyst/catalyst", line 212, in build_target mytarget.run() File "/usr/lib/catalyst/modules/generic_stage_target.py", line 1293, in run apply(getattr(self,x)) File "/usr/lib/catalyst/modules/generic_stage_target.py", line 1155, in empty for x in self.settings[self.settings["spec_prefix"]+"/empty"]: KeyError: 'stage4/empty' Expected Results: empty should not be called.
Created attachment 144598 [details, diff] catalyst-svn-check-empty-key.patch
This is fixed in SVN. Also, this bug also affected livecd/empty, but it's a lot less likely to see a livecd-stage2 spec without a livecd/empty line.
This is in catalyst 2.0.6, which is in the tree and stable. If there's still a problem with this, please REOPEN this bug. Thanks!
