Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 211372 - app-backup/bacula-2.0.3 bug in files "files/x.x.x/bacula-(all|dir)-init".
Summary: app-backup/bacula-2.0.3 bug in files "files/x.x.x/bacula-(all|dir)-init".
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest trivial (vote)
Assignee: Wolfram Schlich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-25 12:52 UTC by Filip Palian (s_n)
Modified: 2008-03-22 16:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Palian (s_n) 2008-02-25 12:52:48 UTC
Affected bacula versions (all):

1.36.3
2.0.3
2.2.4
2.2.5
2.2.6
2.2.7
2.2.8

----

After installing bacula the user should be able to comment out "LOCAL_DB" variable without complications:

# vim /etc/conf.d/bacula-all
 ...
 # If the database server where you store your bacula catalog
 # is on a different machine, please set this to 0.
 #LOCAL_DB=1
 ...

But this operation reults with the following error:

# /etc/init.d/bacula-all start
 * Caching service dependencies ...
/var/lib/init.d/depcache: line 1239: [: -eq: unary operator expected                                                   [ ok ]
 * Starting bacula file daemon ...                                                                                     [ ok ]

----

Suggested fix would be doing an additional check on the "LOCAL_DB" variable. Below is the patch, which should fix the bug:

-- cut --
diff -pruN files/1.36.3/bacula-all-init files.new/1.36.3/bacula-all-init
--- files/1.36.3/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/1.36.3/bacula-all-init	2008-02-25 13:37:13.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/1.36.3/bacula-dir-init files.new/1.36.3/bacula-dir-init
--- files/1.36.3/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/1.36.3/bacula-dir-init	2008-02-25 13:38:05.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.0.3/bacula-all-init files.new/2.0.3/bacula-all-init
--- files/2.0.3/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.0.3/bacula-all-init	2008-02-25 13:41:08.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.0.3/bacula-dir-init files.new/2.0.3/bacula-dir-init
--- files/2.0.3/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.0.3/bacula-dir-init	2008-02-25 13:41:28.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.4/bacula-all-init files.new/2.2.4/bacula-all-init
--- files/2.2.4/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.4/bacula-all-init	2008-02-25 13:41:43.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.4/bacula-dir-init files.new/2.2.4/bacula-dir-init
--- files/2.2.4/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.4/bacula-dir-init	2008-02-25 13:41:52.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.5/bacula-all-init files.new/2.2.5/bacula-all-init
--- files/2.2.5/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.5/bacula-all-init	2008-02-25 13:42:03.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.5/bacula-dir-init files.new/2.2.5/bacula-dir-init
--- files/2.2.5/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.5/bacula-dir-init	2008-02-25 13:42:11.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.6/bacula-all-init files.new/2.2.6/bacula-all-init
--- files/2.2.6/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.6/bacula-all-init	2008-02-25 13:42:30.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.6/bacula-dir-init files.new/2.2.6/bacula-dir-init
--- files/2.2.6/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.6/bacula-dir-init	2008-02-25 13:42:21.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.7/bacula-all-init files.new/2.2.7/bacula-all-init
--- files/2.2.7/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.7/bacula-all-init	2008-02-25 13:42:38.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.7/bacula-dir-init files.new/2.2.7/bacula-dir-init
--- files/2.2.7/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.7/bacula-dir-init	2008-02-25 13:42:46.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.8/bacula-all-init files.new/2.2.8/bacula-all-init
--- files/2.2.8/bacula-all-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.8/bacula-all-init	2008-02-25 13:43:08.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
diff -pruN files/2.2.8/bacula-dir-init files.new/2.2.8/bacula-dir-init
--- files/2.2.8/bacula-dir-init	2008-02-25 13:36:26.000000000 +0100
+++ files.new/2.2.8/bacula-dir-init	2008-02-25 13:42:57.000000000 +0100
@@ -5,7 +5,7 @@
 
 depend() {
 	need net
-	if [ ${LOCAL_DB} -eq 1 ]; then
+	if [ ${LOCAL_DB} && ${LOCAL_DB} -eq 1 ]; then
 		need "%database%"
 	fi
 	use dns
-- cut --
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2008-02-25 13:05:34 UTC
*Please* use attachments instead of pasting diffs inline which totally kills formatting.
Comment 2 Wolfram Schlich (RETIRED) gentoo-dev 2008-03-22 16:32:32 UTC
Fixed in 2.0.3 and 2.2.8 (all others are gone).