Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 210835 (awn-extras-0.2.6) - gnome-extra/avant-window-navigator-extras-0.2.6 version bump
Summary: gnome-extra/avant-window-navigator-extras-0.2.6 version bump
Status: RESOLVED FIXED
Alias: awn-extras-0.2.6
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: William L. Thomson Jr. (RETIRED)
URL: https://launchpad.net/awn-extras/0.2/...
Whiteboard:
Keywords: InVCS
: 214468 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-20 03:01 UTC by Mark Lee
Modified: 2008-10-24 11:16 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
avant-window-navigator-extras-0.2.6.ebuild (avant-window-navigator-extras-0.2.6.ebuild,2.93 KB, text/plain)
2008-03-16 11:21 UTC, srrijkers
Details
avant-window-navigator-extras-0.2.6-r346-gconf-conditional.patch (avant-window-navigator-extras-0.2.6-r346-gconf-conditional.patch,1006 bytes, patch)
2008-03-16 11:22 UTC, srrijkers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lee 2008-02-20 03:01:51 UTC
Hi,

I'm one of the developers of the Avant Window Navigator dock's applets project.  We just released version 0.2.4.  A number of the dependencies have changed, but we have been working with the desktop-effects overlay to have an ebuild that keeps track of the new dependencies.  Please look at their live ebuild to update the DEPENDs and RDEPENDs, in addition to the new USE flags.

http://git.overlays.gentoo.org/gitweb/?p=proj/desktop-effects.git;a=tree;f=gnome-extra/avant-window-navigator-extras;hb=HEAD

Thanks!
Comment 1 William L. Thomson Jr. (RETIRED) gentoo-dev 2008-02-20 04:07:46 UTC
Mark, thanks much will do ASAP.
Comment 2 Mark Lee 2008-03-09 03:11:51 UTC
Forgot to mention that we released 0.2.6 a while back to address some build issues.
Comment 3 srrijkers 2008-03-16 11:21:50 UTC
Created attachment 146299 [details]
avant-window-navigator-extras-0.2.6.ebuild

Here's an updated ebuild for 0.2.6.
Comment 4 srrijkers 2008-03-16 11:22:49 UTC
Created attachment 146301 [details, diff]
avant-window-navigator-extras-0.2.6-r346-gconf-conditional.patch

And the upstream patch it needs to make gconf truly conditional.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2008-03-24 08:07:31 UTC
*** Bug 214468 has been marked as a duplicate of this bug. ***
Comment 6 William L. Thomson Jr. (RETIRED) gentoo-dev 2008-03-25 20:51:56 UTC
Finally got around to bumping this. Thanks for the ebuild and patch. As stated in other bug, please just patches next time. Need to review the deps, I did not modify them much aside from dropping libgmail. Seems there are redundant deps in the -extras package that are also in the main awn package. No need for them to be in the extras, since the extras deps on the main awn package and all it's deps.

Otherwise I kept most other changes to ebuild. Although the python stuff in pkg_postinst and pkg_postrm I did not add to the main awn package. Likely need to go back and do that. But really need to understand what it does first :)

Otherwise we are good here as well. Please let me know if I need to change anything, patches are always welcome. Thanks again for contributions.
Comment 7 srrijkers 2008-03-25 21:56:55 UTC
This goes for awn and awn-extras:

- The deps are from the configure script and should be correct. Please note that there is no libgmail dep in the ebuild I posted.
- The python stuff was added to the awn-0.2.1-r1 ebuild in the tree by Gilles Dartiguelongue wrt bug #207667; they should be relevant for awn-extras as well. I just copied them.
- I see you've removed the glib dep for awn when USE="gnome". Feel free to do so, but do note that the configure script checks for it explicitly.
- What's up with the gconf USE-flag? This should be grouped with the gnome-flag like every other ebuild in the tree does.
Comment 8 William L. Thomson Jr. (RETIRED) gentoo-dev 2008-03-25 23:45:05 UTC
(In reply to comment #7)
> This goes for awn and awn-extras:
> 
> - The deps are from the configure script and should be correct. Please note
> that there is no libgmail dep in the ebuild I posted.

I already dropped that dep in the ebuild I committed to tree.

> - The python stuff was added to the awn-0.2.1-r1 ebuild in the tree by Gilles
> Dartiguelongue wrt bug #207667; they should be relevant for awn-extras as well.

You don't add the same deps to two ebuilds when one pulls in the other. So we add the stuff to either awn or awn-extras, but not both.

> I just copied them.
> - I see you've removed the glib dep for awn when USE="gnome". Feel free to do
> so, but do note that the configure script checks for it explicitly.
> - What's up with the gconf USE-flag? This should be grouped with the gnome-flag
> like every other ebuild in the tree does.

Those weren't my changes, I was syncing the ebuild with a live on in the xeffects overlay I believe. That overlay is MIA, but I am pretty sure the live ebuild is in another. So that's where the optional glib dep came from and gconf. Also vala and other stuff that wasn't in the ebuild in tree.


Comment 9 srrijkers 2008-03-26 00:08:49 UTC
Let me clarify:
- with python stuff I mean the "python_mod_optimize" stuff and the eclass inherit.
- I tried to say that even with the gnome (and / or xfce) flag set, configure checks for glib. It just doesn't check for a specific version (this applies to awn - not extras, for clarity's sake)
- the xeffects ebuilds usually contain a whole slew of non-standard / unnessecary USE-flags. The standard way of doing this seems to be to use the gnome-flag for gconf support, like I did in my ebuild.

wrt the extras ebuild:
- please hide the (remaining, non-duplicate) gnome deps behind the gnome USE-flag. This means the deps required by the --with-gnome flag. They're listed in my ebuild.
Comment 10 William L. Thomson Jr. (RETIRED) gentoo-dev 2008-03-26 00:15:50 UTC
(In reply to comment #9)
> Let me clarify:
> - with python stuff I mean the "python_mod_optimize" stuff and the eclass
> inherit.

Ah ok, I was planning on adding that to awn as well with the revision. Sorry thought you were talking deps :)

> - I tried to say that even with the gnome (and / or xfce) flag set, configure
> checks for glib. It just doesn't check for a specific version (this applies to
> awn - not extras, for clarity's sake)

Yes, but glib is brought in as a dep of gnome or xfce. Actually technically gtk pulls it in as well. So really I can drop that dep all together. Since gtk is not conditional. However it was in the one in the overlay, and although gtk pulls it in. It's not guaranteed to be 2.15. Even if awn isn't looking for it, I believe it will fail to compile unless it has >= glib 2.15. At least that's my  take on it  :)

> - the xeffects ebuilds usually contain a whole slew of non-standard /
> unnessecary USE-flags. The standard way of doing this seems to be to use the
> gnome-flag for gconf support, like I did in my ebuild.

Yeah I am going that route. As gconf I don't believe is used outside gnome, so kinda redundant flags and pointless. I see you did the same with doc.

> wrt the extras ebuild:
> - please hide the (remaining, non-duplicate) gnome deps behind the gnome
> USE-flag. This means the deps required by the --with-gnome flag. They're listed
> in my ebuild.

Sorry must have missed that. Again patches man :)


Comment 11 Mart Raudsepp gentoo-dev 2008-03-26 00:24:27 UTC
python_mod_optimize requires ${ROOT} in front of its argument.
python_mod_cleanup on the other hand must not have it.
_optimize doesn't pass it, _cleanup does. Inconsistency, but we have to live with it for now..
That is to say that the optimize version needs a ${ROOT} in front of /usr/lib in this ebuild as well, and any other ones that call python_mod_optimize.
Comment 12 srrijkers 2008-03-27 21:26:51 UTC
One final thing: please re-add the conditional dep on dev-python/gst-python if USE="gnome". This package is not pulled in indirectly.
Comment 13 William L. Thomson Jr. (RETIRED) gentoo-dev 2008-03-27 21:51:57 UTC
added