Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 210807 - catalyst-2.0.6_pre6: livecd-stage2 clean fails due to absent directories
Summary: catalyst-2.0.6_pre6: livecd-stage2 clean fails due to absent directories
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: Catalyst (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Catalyst Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-20 00:44 UTC by Kristoffer
Modified: 2008-06-19 16:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Makes catalyst check if the directories exist running find. (livecd-stage2-controller-clean-fix.patch,864 bytes, patch)
2008-02-20 00:56 UTC, Kristoffer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristoffer 2008-02-20 00:44:41 UTC
When targets/livecd-stage2/livecd-stage2-controller.sh is called for clean, it will run find on /usr/lib, /usr/lib32 and last /usr/lib64. When I build x86 systems, /usr/lib64 doesn't exist, so the last find call exits with an error code that will be captures by calling python script (at modules/generic_stage_target.py:1140) and make it and thus catalyst fail in turn.

This is with catalyst-2.0.6_pre6 (didn't happen with 2.0.5).

Reproducible: Always

Steps to Reproduce:
1. use catalyst for an x86 livecd-stage2 

Actual Results:  
Catalyst exits with an error.

Expected Results:  
Catalyst should make find ignore the non-existent directories and continue on instead.
Comment 1 Kristoffer 2008-02-20 00:56:04 UTC
Created attachment 144040 [details, diff]
Makes catalyst check if the directories exist running find.

The provided patch fixes the problem for me at least.

Depending on what exact behaviour you're after for symbolic links you might want consider adding the -H (or -L) option for the find command in the patch since /usr/lib usually is a symbolic link pointing to /usr/lib64 on x86_64. But the patch already handles /usr/lib64 specifically, so it's perhaps superfluous.
Comment 2 Kristoffer 2008-02-20 01:02:02 UTC
I just realized that an even easier and more minimalistic fix would be to simply replace all three find calls with one using a wildcard, i.e.:

find ${clst_chroot_path}/usr/lib* -iname "*.pyc" -exec rm -f {} \;
Comment 3 Andrew Gaffney (RETIRED) gentoo-dev 2008-02-20 15:18:55 UTC
I prefer your original patch as it's more "explicit" and it doesn't pick up /usr/libexec (which may or may not matter). This is in SVN. Thanks.
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2008-06-19 16:05:35 UTC
This is in catalyst 2.0.6, which is in the tree and stable.  If there's still a problem with this, please REOPEN this bug.

Thanks!