Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 21067 - Patch to make xmms-sid more useable in xmms-1.2.7
Summary: Patch to make xmms-sid more useable in xmms-1.2.7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: J. Ellis (RETIRED)
URL: http://kreiger.linuxgods.com/files/so...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-15 11:18 UTC by Christoph Richter
Modified: 2003-09-15 04:26 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
The patch for xmms (xmms-songpos) (xmms-songpos.patch-1.2.7,13.70 KB, patch)
2003-05-15 11:23 UTC, Christoph Richter
Details | Diff
A stripped down version of the songpos-patch modified to fit xmms-1.2.8 (xmms-songpos.patch-1.2.8,8.75 KB, patch)
2003-09-14 05:28 UTC, Christoph Richter
Details | Diff
A patch against xmms-1.2.8-r1.ebuild to include the xmms-sid-songpos patch (xmms-1.2.8-r2.patch,2.50 KB, patch)
2003-09-14 05:32 UTC, Christoph Richter
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Richter 2003-05-15 11:18:50 UTC
From README.songpos in xmms-sid:

'The XMMS-SID plugin will work much better if you install the song
position patch ("xmms-songpos.patch*") which makes it possible for
the plugin to use the position slider to choose subtunes. 
It also patches some other plugins (like MikMod plugin) for
improved features.'

Download the patch here:
http://kreiger.linuxgods.com/files/sources/xmms-songpos.patch-1.2.7
put it into portage/media-sound/xmms/files

and apply this trivial patch to the ebuild (xmms-1.27-r20.ebuild):

45a46,48
>       # apply songpos patch to make the position slider useable for xmms-sid
(to chose subtunes)
>       epatch ${FILESDIR}/xmms-songpos.patch
>

You have to rebuild xmms-sid, too, to use the new functionality. Maybe a comment
stating that in the ebuild would be nice.
Comment 1 Christoph Richter 2003-05-15 11:23:33 UTC
Created attachment 12029 [details, diff]
The patch for xmms
(xmms-songpos)
Comment 2 Christoph Richter 2003-05-15 11:25:39 UTC
Comment on attachment 12029 [details, diff]
The patch for xmms
(xmms-songpos)

should go into portage/media-sound/xmms/files
Comment 3 J. Ellis (RETIRED) gentoo-dev 2003-05-17 04:24:43 UTC
Commited in r21, ~x86 masked. Let me know if there are any issues.

Thanks!
Comment 4 Jonathan Hitchcock 2003-05-25 18:40:03 UTC
This patch breaks a lot of things.  For example, 'xmms -t' no longer pauses the song, and so on.  xmmsctrl can't read the title.  And so on.

The patch changes xmms-1.2.7/xmms/controlsocket.h, and adds CMD_SEEK into the middle of the enum.  The effect of this, as far as I can tell, is to renumber the commands, so that telling xmms to, for example, pause, then becomes something completely different (I haven't investigated far enough).

I edited the patch to put CMD_SEEK at the end of the enum (so that it doesn't mess any of the others around), and everything started working again.  I'm not sure what effect this has on the functionality that the patch is supposed to add, because I don't use the -SID plugin (whatever that is).  I just don't think that a patch that tries to add functionality should break things this badly ;-)
Comment 5 J. Ellis (RETIRED) gentoo-dev 2003-05-26 00:48:54 UTC
Well, that wasn't very bright of me, was it? ;-)

I'll remove the patch for now, re-open this bug, and take a crack at fixing the patch along the lines that you suggest.
Comment 6 SpanKY gentoo-dev 2003-09-12 20:55:11 UTC
xmms-1.2.8-r1 is out so you might wanna update that patch again ...
Comment 7 Christoph Richter 2003-09-14 05:28:50 UTC
Created attachment 17687 [details, diff]
A stripped down version of the songpos-patch modified to fit xmms-1.2.8

I stripped off all the stuff that's not directly related to the patch's
purpose. So only the xmms-sid related song selection is left.
I also made it work with xmms-1.2.8 out of the box.

The mentioned stuff that got broken works for me flawlessly now (xmms -t,
xmmsctrl title,...). Maybe one has to re-emerge xmmsctrl!?

This patch should go into media-sound/xmms/files/
Comment 8 Christoph Richter 2003-09-14 05:32:30 UTC
Created attachment 17688 [details, diff]
A patch against xmms-1.2.8-r1.ebuild to include the xmms-sid-songpos patch

The new ebuild includes the new xmms-sid-songpos patch as well a einfo-comment
in postinst() that proposes to re-emerge xmms-sid.
Comment 9 Seemant Kulleen (RETIRED) gentoo-dev 2003-09-15 04:26:23 UTC
added to -r2, thanks christoph
Comment 10 Seemant Kulleen (RETIRED) gentoo-dev 2003-09-15 04:26:37 UTC
added to -r2, thanks christoph