Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 210445 - app-emulation/xen-tools - xendomains stop should stop domains in reverse order (of xendomains start)
Summary: app-emulation/xen-tools - xendomains stop should stop domains in reverse orde...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Xen Devs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-17 09:01 UTC by Joris Dobbelsteen
Modified: 2008-09-01 00:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joris Dobbelsteen 2008-02-17 09:01:31 UTC
xendomains stop should stop the domains in the reverse order they were started. If a specific order is desired this can be enforced then (e.g. expect under normal conditions that domain A to be active when domain B is).

Reproducible: Always




I used the following lines:
---
for dom in $(ls "${AUTODIR}/"* 2>/dev/null | sort 2>/dev/null); do
for dom in $(ls "${AUTODIR}/"* 2>/dev/null | sort -r 2>/dev/null); do
---
in the start(), respectivily, stop() functions instread of
---
for dom in $(ls "${AUTODIR}/"* 2>/dev/null); do
---

Line in start() function is normally not needed, as underlaying file system or ls already presents the files in sorted order.
Comment 1 Robert Buchholz (RETIRED) gentoo-dev 2008-09-01 00:47:11 UTC
Thank you for your bug report. I hope it is fixed with the following commit. Please let me know if it works, or not.

*xen-tools-3.3.0 (01 Sep 2008)

  01 Sep 2008; Robert Buchholz <rbu@gentoo.org>
  +files/xen-tools-3.3.0--as-needed.patch,
  +files/xen-tools-3.3.0-nostrip.patch,
  +files/xen-tools-3.3.0-xen-detect-nopie-fix.patch, files/xendomains.confd,
  files/xendomains.initd, metadata.xml, -xen-tools-3.2.0.ebuild,
  +xen-tools-3.3.0.ebuild:
  Version bump to Xen 3.3 (bug #201792). Fixes bugs:
   * Add USE flags for ACM and FLASK Xen Security Modules
   * Properly compile and uninstall python bytecode
   * RDEPEND on pyxml (bug #201255)
   * Remove libvncserver dependency
   * Shutdown xendomains in reverse start order (bug #210445)
   * Allow for parallel shutdown of xendomains (bug #162833)
   * Check that python is built with threading (bug #236092)
Comment 2 Robert Buchholz (RETIRED) gentoo-dev 2008-09-01 00:48:08 UTC
As a feedback to your patch: The sort needs to be piped *after* the 2> redirect, otherwise an error is printed if there are no domains in AUTODIR.