Bug 210287 – glsa-check -f affected ignores injected glsas

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Mike Doty (RETIRED) 2008-02-15 22:06:41 UTC]

apache1 ~ # glsa-check -i 200711-17
injecting 200711-17

apache1 ~ # glsa-check -f affected
fixing 200711-17
>>> merging dev-ruby/rails-1.2.5
Calculating dependencies /
!!! All ebuilds that could satisfy "=dev-ruby/rails-1.2.5" have been masked.

'glsa-check -f new' works.

Please fix glsa-check -f affected to respect the injected list

[Comment 1 Mike Doty (RETIRED) 2008-02-15 22:08:08 UTC]

app-portage/gentoolkit-0.2.3-r1 and earlier versions affected. 'all' target broken as well.

[Comment 2 [e-mail] 2008-02-22 18:55:27 UTC]

Created attachment 144374 [details, diff]
glsa-check_fixonlyaffected.patch

This should only be applied to the versions Mike specified in comment #1. This has already been fixed later releases.

[Comment 3 [e-mail] 2008-02-25 18:14:39 UTC]

Created attachment 144608 [details, diff]
gentoolkit-0.2.3-r2.ebuild-fixonlyaffected.patch

Ebuild patch to take gentoolkit-0.2.3-r1 to gentoolkit-0.2.3-r2 and patch this bug.

Requires attachment #144374 [details, diff] to be in FILESDIR named gentoolkit-0.2.3-glsa-check_fixonlyaffected.patch

[Comment 4 Robert Buchholz (RETIRED) 2009-05-07 13:35:32 UTC]

This has been fixed at least in gentoolkit-0.2.4 via this commit:

commit 29f6d92a293eccf9f3c0226adab7a955b8e83504
Author: genone <genone@e84c3a59-eaf8-0310-85df-8a9fcd7b4891>
Date:   Tue Oct 9 19:45:19 2007 +0000

    base 'affected' target on 'new' instead of 'all'

    git-svn-id: svn://anonsvn.gentoo.org/gentoolkit/trunk/src/glsa-check@452 e84c3a59-eaf8-0310-85df-8a9fcd7b4891

diff --git a/glsa-check b/glsa-check
index 62e4449..07d1005 100644
--- a/glsa-check
+++ b/glsa-check
@@ -162,8 +162,8 @@ if "all" in params:
        glsalist = completelist
        params.remove("all")
 if "affected" in params:
-       # maybe this should be todolist instead
-       for x in completelist:
+       # replaced completelist with todolist on request of wschlich
+       for x in todolist:
                try:
                        myglsa = Glsa(x, glsaconfig)
                except (GlsaTypeException, GlsaFormatException), e: