Bug 209626 – Patches for qt4.eclass and qt4-build.eclass to make them ready for eclass-manpages

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description mren 2008-02-11 02:01:31 UTC]

Patches for qt4.eclass and qt4-build.eclass so that eclass-manpages will automatically create man pages for them.

Reproducible: Always

[Comment 1 mren 2008-02-11 02:02:24 UTC]

Created attachment 143177 [details, diff]
qt4-build.eclass.patch

The patch for qt4-build.eclass

[Comment 2 mren 2008-02-11 02:03:10 UTC]

Created attachment 143179 [details, diff]
qt4.eclass.patch

The patch for qt4.eclass

[Comment 3 mren 2008-02-12 00:50:20 UTC]

Created attachment 143259 [details, diff]
qt4-build.eclass.patch

Sorry, forgot one function

[Comment 4 Markos Chandras (RETIRED) 2009-05-21 23:23:06 UTC]

Created attachment 192075 [details]
qt4-build eclass updated to latest version

Any comments are welcomed. I will move it to tree withing the next 3 days

Thanks

[Comment 5 Davide Pesavento (RETIRED) 2009-05-22 19:37:56 UTC]

A few typos:
space separated -> space-separated
actuall -> actual
wether -> whether
much standard things more -> (what do you mean?)
separeted -> separated
qmake-core -> I guess you mean x11-libs/qt-core
skip_project_genereation_patch -> skip_project_generation_patch

Judging from the leading underscore, _qt_build_with_use() seems to be for internal use only. I don't know what the policy is, but maybe internal eclass functions should _not_ be documented with eclass-doc...?

Apart from that, it looks good to me :)

[Comment 6 Markos Chandras (RETIRED) 2009-05-22 22:21:40 UTC]

Thanks Davide, I removed the definition for the internal function. I also fixed the other issues

Commited and closed now

If there are any objection feel free to reopen it or fix it directly to tree