Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 209579 - net-misc/scponly - add scp use flag for scp-compat
Summary: net-misc/scponly - add scp use flag for scp-compat
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest enhancement
Assignee: MATSUU Takuto (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-10 19:39 UTC by Johan Ymerson
Modified: 2008-11-13 23:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
scponly ebuild with added scp use flag (scponly-4.8.ebuild,4.11 KB, text/plain)
2008-02-10 19:41 UTC, Johan Ymerson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Ymerson 2008-02-10 19:39:58 UTC
scponly doesn't compile with scp compatibility per default. I suggest adding a "scp" use flag to control if scp compatibility should be build in or not.


Reproducible: Always
Comment 1 Johan Ymerson 2008-02-10 19:41:54 UTC
Created attachment 143154 [details]
scponly ebuild with added scp use flag
Comment 2 Per Pomsel 2008-02-27 15:13:19 UTC
Or why not enableing "--enable-scp-compat" per default? The package is named "scponly", but without working scp code it's almost useless.
Comment 3 Stuart Shelton 2008-04-29 19:54:20 UTC
Additionally the package description is, somewhat ironically, "A tiny pseudoshell which only permits scp and sftp".

Note that the previous ebuild for scponly-4.3 *did* have scp support enabled (probably by default) - so there should be a great big warning on merging this package that scp will no longer work: it took me an hour of debugging and look at strace output to work out why a chrooted scponly environment no longer worked after the package upgrade :(
Comment 4 Christian Gut 2008-06-21 11:11:10 UTC
Actually read the SECURITY document. Enabling scp-compat exposes you to a higher risk. But adding a useflag is perfectly reasonable for me. (Just had to remerge it because of scp missing).

So +1 for the attached ebuild
Comment 5 Dave Hughes 2008-07-21 10:37:30 UTC
I'm not so sure adding --enable-scp-compat by default does expose you to a higher risk. Reading the SECURITY document, it indicates that "by enabling scp and/or scp compatibility, more programs will need to be installed in the chroot which increases the risk". If the added risk comes solely from the extra programs in the chroot (as the above implies) then if the user doesn't change their chroot environment, their risk remains the same.

Still, in the interests of caution (and because I could very well be wrong!), I'd like to see the USE flag added.
Comment 6 Stefan Briesenick (RETIRED) gentoo-dev 2008-11-13 23:04:48 UTC
fixed in CVS.