Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 209120 - sci-chemistry/xds-20080602 version bump
Summary: sci-chemistry/xds-20080602 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Chemistry-Related Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2008-02-06 11:20 UTC by Justin Lecher (RETIRED)
Modified: 2008-08-03 22:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
sci-chemistry/xds-20071206.ebuild (xds-20071206.ebuild,1.42 KB, text/plain)
2008-02-06 11:21 UTC, Justin Lecher (RETIRED)
Details
xds-20071206.ebuild (xds-20071206.ebuild,1.22 KB, text/plain)
2008-02-23 16:33 UTC, Justin Lecher (RETIRED)
Details
xds-20071206.ebuild (xds-20071206.ebuild,1.29 KB, text/plain)
2008-02-23 16:37 UTC, Justin Lecher (RETIRED)
Details
xds-20071206.ebuild (xds-20071206.ebuild,1.29 KB, text/plain)
2008-02-23 17:00 UTC, Justin Lecher (RETIRED)
Details
xds-20071206.ebuild (xds-20071206.ebuild,1.28 KB, text/plain)
2008-02-23 17:35 UTC, Justin Lecher (RETIRED)
Details
xds-20071206.ebuild (xds-20071206.ebuild,1.22 KB, text/plain)
2008-02-23 17:47 UTC, Justin Lecher (RETIRED)
Details
sci-chemistry/xds-bin-20071206.ebuild (xds-bin-20071206.ebuild,1.18 KB, text/plain)
2008-03-13 13:21 UTC, Justin Lecher (RETIRED)
Details
xds-bin-20071206.ebuild (xds-bin-20071206.ebuild,1.18 KB, text/plain)
2008-03-13 14:52 UTC, Justin Lecher (RETIRED)
Details
sci-chemistry/xds-bin-20071206.ebuild (xds-bin-20071206.ebuild,1.17 KB, text/plain)
2008-03-13 15:09 UTC, Justin Lecher (RETIRED)
Details
xds-bin-20071206.ebuild (xds-bin-20071206.ebuild,1.22 KB, text/plain)
2008-03-14 07:55 UTC, Justin Lecher (RETIRED)
Details
xds-bin-20080602.ebuild (xds-bin-20080602.ebuild,1.33 KB, text/plain)
2008-06-21 15:52 UTC, Justin Lecher (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2008-02-06 11:20:51 UTC
http://www.mpimf-heidelberg.mpg.de/~kabsch/xds/

Should be available for protein structure science.

Perhaps the science overlay.

Reproducible: Always



Reproducible: Always
Comment 1 Justin Lecher (RETIRED) gentoo-dev 2008-02-06 11:21:24 UTC
Created attachment 142806 [details]
sci-chemistry/xds-20071206.ebuild

sci-chemistry/xds-20071206.ebuild
Comment 2 Donnie Berkholz (RETIRED) gentoo-dev 2008-02-22 19:49:57 UTC
> # Copyright 1999-2008 Gentoo Foundation                         [/home/donnie]
> # Distributed under the terms of the GNU General Public License v2
> # $Header: $
>
> inherit eutils
>
> DESCRIPTION="X-ray Detector Software for processing single-crystal monochromatic diffraction data recorded by the rotation method."
> SRC_URI="ftp://ftp.mpimf-heidelberg.mpg.de/pub/kabsch/XDS-linux_ifc_Intel+AMD.tar.gz
>                ftp://ftp.mpimf-heidelberg.mpg.de/pub/kabsch/XDS_html_doc.tar.gz"
> HOMEPAGE="http://www.mpimf-heidelberg.mpg.de/~kabsch/xds/"
> RESTRICT="primaryuri"

Why the restriction?

> LICENSE="as-is nonprofit"

Is this really accurate?

> SLOT="0"
> KEYWORDS="x86"

Ebuilds don't start marked stable, they should be ~arch first.

> IUSE="smp X"
> RDEPEND="X? ( x11-libs/libXdmcp
>                         x11-libs/libXau
>                         x11-libs/libX11 )"
> DEPEND="${RDEPEND}"
>
> src_install() {
>       exeinto /opt/xray/XDS
>       doexe XDS-linux_ifc_Intel+AMD/*
>       dosym /opt/xray/XDS/xdsconv /usr/bin/xdsconv
>       if use smp
>       then
>               dosym /opt/xray/XDS/xds_par /usr/bin/xds
>               dosym /opt/xray/XDS/xscale_par /usr/bin/xscale
>               dosym /opt/xray/XDS/xds /usr/bin/xds_single
>               dosym /opt/xray/XDS/xscale /usr/bin/xscale_single
>       else
>               dosym /opt/xray/XDS/xds_par /usr/bin/xds_par
>               dosym /opt/xray/XDS/xscale_par /usr/bin/xscale_par
>               dosym /opt/xray/XDS/xds /usr/bin/xds
>               dosym /opt/xray/XDS/xscale /usr/bin/xscale
>       fi

These symlinks are the wrong approach. Instead you should be adding the directory to PATH using a file in /etc/env.d/. You can probably find some examples by looking through that directory on your system, and there are utility functions for installing it (doenvd, newenvd).

>       if use !X; then

I prefer 'if ! use X' -- the other way is a hack primarily intended for use_enable() and use_with().

>               rm ${D}/opt/xray/XDS/VIEW
>       else
>               dosym /opt/xray/XDS/VIEW /usr/bin/VIEW
>       fi
>       dohtml -r XDS_html_doc/*
>       dodoc XDS_html_doc/html_doc/INPUT_templates/*
> }
>
> pkg_postinst(){
>       einfo "This package will expire at"
>       einfo "Expiration date: June 30, 2008"
> }
>
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2008-02-23 16:32:35 UTC
(In reply to comment #2)
> > # Copyright 1999-2008 Gentoo Foundation                         [/home/donnie]
> > # Distributed under the terms of the GNU General Public License v2
> > # $Header: $
> >
> > inherit eutils
> >
> > DESCRIPTION="X-ray Detector Software for processing single-crystal monochromatic diffraction data recorded by the rotation method."
> > SRC_URI="ftp://ftp.mpimf-heidelberg.mpg.de/pub/kabsch/XDS-linux_ifc_Intel+AMD.tar.gz
> >                ftp://ftp.mpimf-heidelberg.mpg.de/pub/kabsch/XDS_html_doc.tar.gz"
> > HOMEPAGE="http://www.mpimf-heidelberg.mpg.de/~kabsch/xds/"
> > RESTRICT="primaryuri"
> 
> Why the restriction?
Because This was one of my first ebuilds and I figured out later that it should be mirror. Shame on me but I reviewed it bad.
> 
> > LICENSE="as-is nonprofit"
> 
> Is this really accurate?
Kabsch says:
XDS is free of charge for non-commercial applications and available here for downloading. Note, that the executables of the package will expire on June 30, 2008. For industrial usage of XDS a license is required (e-mail enquiry : Wolfgang.Kabsch@mpimf-heidelberg.mpg.de).
For me that means free-noncomm.
> 
> > SLOT="0"
> > KEYWORDS="x86"
> 
> Ebuilds don't start marked stable, they should be ~arch first.
Same as above, first ebuild, personal use and bad review.
> 
> > IUSE="smp X"
> > RDEPEND="X? ( x11-libs/libXdmcp
> >                         x11-libs/libXau
> >                         x11-libs/libX11 )"
> > DEPEND="${RDEPEND}"
> >
> > src_install() {
> >       exeinto /opt/xray/XDS
> >       doexe XDS-linux_ifc_Intel+AMD/*
> >       dosym /opt/xray/XDS/xdsconv /usr/bin/xdsconv
> >       if use smp
> >       then
> >               dosym /opt/xray/XDS/xds_par /usr/bin/xds
> >               dosym /opt/xray/XDS/xscale_par /usr/bin/xscale
> >               dosym /opt/xray/XDS/xds /usr/bin/xds_single
> >               dosym /opt/xray/XDS/xscale /usr/bin/xscale_single
> >       else
> >               dosym /opt/xray/XDS/xds_par /usr/bin/xds_par
> >               dosym /opt/xray/XDS/xscale_par /usr/bin/xscale_par
> >               dosym /opt/xray/XDS/xds /usr/bin/xds
> >               dosym /opt/xray/XDS/xscale /usr/bin/xscale
> >       fi
> 
> These symlinks are the wrong approach. Instead you should be adding the
> directory to PATH using a file in /etc/env.d/. You can probably find some
> examples by looking through that directory on your system, and there are
> utility functions for installing it (doenvd, newenvd).
Okey!
> 
> >       if use !X; then
> 
> I prefer 'if ! use X' -- the other way is a hack primarily intended for
> use_enable() and use_with().
I understand and learn.
> 
> >               rm ${D}/opt/xray/XDS/VIEW
> >       else
> >               dosym /opt/xray/XDS/VIEW /usr/bin/VIEW
> >       fi
> >       dohtml -r XDS_html_doc/*
> >       dodoc XDS_html_doc/html_doc/INPUT_templates/*
> > }
> >
> > pkg_postinst(){
> >       einfo "This package will expire at"
> >       einfo "Expiration date: June 30, 2008"
> > }
> >
> 

New updated ebuild available!

Comment 4 Justin Lecher (RETIRED) gentoo-dev 2008-02-23 16:33:28 UTC
Created attachment 144419 [details]
xds-20071206.ebuild
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2008-02-23 16:37:05 UTC
Created attachment 144420 [details]
xds-20071206.ebuild
Comment 6 Justin Lecher (RETIRED) gentoo-dev 2008-02-23 17:00:06 UTC
Created attachment 144423 [details]
xds-20071206.ebuild

learned something new from bug 209122. Thanks Donnie!!
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2008-02-23 17:35:12 UTC
Created attachment 144426 [details]
xds-20071206.ebuild

Doesn't have buildtime deps.
Comment 8 Justin Lecher (RETIRED) gentoo-dev 2008-02-23 17:47:46 UTC
Created attachment 144428 [details]
xds-20071206.ebuild

xray removed
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2008-03-13 05:52:35 UTC
OK, new set of questions and comments:

- Can it work in /opt/xds instead of /opt/XDS ?
- Is smp actually deleting the non-parallel binaries, or deleting symlinks to them?
- Explicitly set DEPEND="" so that RDEPEND doesn't become DEPEND too.
- Should probably be named xds-bin instead of xds.
- If you run repoman on it, it'll tell you to quote some variables.
- Use relative symlinks (e.g., dosym foo_bar /opt/xds/foo)
Comment 10 Justin Lecher (RETIRED) gentoo-dev 2008-03-13 13:20:24 UTC
(In reply to comment #9)
> OK, new set of questions and comments:
> 
> - Can it work in /opt/xds instead of /opt/XDS ?
Of course it can do. For me the program is XDS, thats why I put it in that. Changed!
> - Is smp actually deleting the non-parallel binaries, or deleting symlinks to
> them?
It is deleting the non-parallel binaries and setting symlinks to the parallel. Do you think the non-parallel should be kept?
> - Explicitly set DEPEND="" so that RDEPEND doesn't become DEPEND too.
Done!
> - Should probably be named xds-bin instead of xds.
Yeah, but I hate this degradation although it is true. 
> - If you run repoman on it, it'll tell you to quote some variables.
Corrected!
> - Use relative symlinks (e.g., dosym foo_bar /opt/xds/foo)
Done!
> 

Comment 11 Justin Lecher (RETIRED) gentoo-dev 2008-03-13 13:21:20 UTC
Created attachment 145996 [details]
sci-chemistry/xds-bin-20071206.ebuild
Comment 12 Justin Lecher (RETIRED) gentoo-dev 2008-03-13 14:52:46 UTC
Created attachment 146016 [details]
xds-bin-20071206.ebuild

-* added
Comment 13 Justin Lecher (RETIRED) gentoo-dev 2008-03-13 15:09:41 UTC
Created attachment 146017 [details]
sci-chemistry/xds-bin-20071206.ebuild
Comment 14 Donnie Berkholz (RETIRED) gentoo-dev 2008-03-14 03:53:05 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > OK, new set of questions and comments:
> > 
> > - Can it work in /opt/xds instead of /opt/XDS ?
> Of course it can do. For me the program is XDS, thats why I put it in that.
> Changed!

/opt/xds-bin, my bad.

> > - Is smp actually deleting the non-parallel binaries, or deleting symlinks to
> > them?
> It is deleting the non-parallel binaries and setting symlinks to the parallel.
> Do you think the non-parallel should be kept?

It needs to be consistent either way. Either always install 1 set of binaries, or always install 2 sets of binaries. I'd recommend 1 set (deleting _par* on USE="-smp").

> > - Explicitly set DEPEND="" so that RDEPEND doesn't become DEPEND too.
> Done!
> > - Should probably be named xds-bin instead of xds.
> Yeah, but I hate this degradation although it is true. 
> > - If you run repoman on it, it'll tell you to quote some variables.
> Corrected!
> > - Use relative symlinks (e.g., dosym foo_bar /opt/xds/foo)
> Done!
> > 
> 

Comment 15 Justin Lecher (RETIRED) gentoo-dev 2008-03-14 07:54:31 UTC
(In reply to comment #14)
> /opt/xds-bin, my bad.
Okey everbody should see it. I don't want to be the "bin man"!
> It needs to be consistent either way. Either always install 1 set of binaries,
> or always install 2 sets of binaries. I'd recommend 1 set (deleting _par* on
> USE="-smp").
> 
Right!
Comment 16 Justin Lecher (RETIRED) gentoo-dev 2008-03-14 07:55:03 UTC
Created attachment 146082 [details]
xds-bin-20071206.ebuild
Comment 17 Justin Lecher (RETIRED) gentoo-dev 2008-06-21 15:52:12 UTC
Created attachment 157945 [details]
xds-bin-20080602.ebuild

New version was released. This is the updated ebuild. I also introduced the nessecary fetch rstriction.
Comment 18 Donnie Berkholz (RETIRED) gentoo-dev 2008-08-03 22:29:57 UTC
I just added this to the tree, with a few small changes. Thanks for all your work on this!