OSS/commercial breaks with latest stable gentoo kernel, this patch makes it compile for me. --- sndshield.c.orig 2003-05-10 19:09:32.000000000 +0100 +++ sndshield.c 2003-05-10 12:16:38.000000000 +0100 @@ -770,11 +770,11 @@ udi_remap_page_range (void *vma, unsigned long from, unsigned long to, unsigned long size, pgprot_t prot) { -#ifdef NEW_MM - return remap_page_range (vma, from, to, size, prot); -#else +//#ifdef NEW_MM +// return remap_page_range (vma, from, to, size, prot); +//#else return remap_page_range (from, to, size, prot); -#endif +//#endif } void Reproducible: Always Steps to Reproduce: 1. Install OSS/Commercial with latest gentoo-sources kernel 2. Installation app will tell you it doesnt have a precompiled module suitable for your kernel 3. Attempt to compile locally, observe errors. Apply patch and it works. Expected Results: A minor revision shouldnt break compatability. If you are going to change stuff that is going to break things, you _MUST_ mark them deprecated for a release, using #warning for example, or with messages in menuconfig help, or in post_inst messages. The same thing happened with blowfish module in last stable kernel, thankfully that was fixed with this release. PLEASE PLEASE PLEAS Start marking stuff deprecated for a release _BEFORE_ changing it. gcc -D__KERNEL__ -DMODULE -I/lib/modules/`uname -r`/build/include -I/usr/src/linux-`uname -r`/include -I/usr/src/linux-2.4/include -I/usr/src/linux/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -pipe -DMODVERSIONS `./find_arch.sh` -ffixed-8 -c sndshield.c -o sndshield sndshield.c: In function `udi_remap_page_range': sndshield.c:774: warning: passing arg 1 of `remap_page_range_R69d01e73' makes integer from pointer without a cast sndshield.c:774: incompatible type for argument 4 of `remap_page_range_R69d01e73' sndshield.c:774: too many arguments to function `remap_page_range_R69d01e73'
gentoo-sources is a highly optimized set of patches that give the enduser quite a bit of flexibility - even the ability to choose your vm (aavm or rmap). rmap is the default. did you try this with aavm? otherwise, i think you've found your fix and it was to your sources not mine. as far as blowfish and things changing, we had a bit of redesign in the kernel over the past 2.5 months and things have only improved. blowfish was taken out by the past maintainer inadvertantly when USAGI was added, r2 came out for the ptrace fix only. things have been put back in as of r3 and i do not see anything like this occurring in the future. as of now r5 is pretty solid. sorry if you're the one who uses a piece of software we could not test against as it is not free nor do we have an ebuild or access to it. patches for software like this really needs to come from them. the standard vm we use is backported from 2.5. Regards, Jay Pfeifer Gentoo Linux Developer Core System/Kernel
*** Bug 20806 has been marked as a duplicate of this bug. ***
