Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207247 - packages using gems.eclass will succeed even when gem install fails with rubygems-1.0.1
Summary: packages using gems.eclass will succeed even when gem install fails with ruby...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Ruby Team
URL: http://rubyforge.org/tracker/index.ph...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-24 05:01 UTC by Josh Nichols (RETIRED)
Modified: 2008-12-20 12:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
work around the missing exit status until rubygems is fixed (fix-gems-eclass-missing-exit-status.patch,981 bytes, patch)
2008-02-17 13:28 UTC, Marco Matthies
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Nichols (RETIRED) gentoo-dev 2008-01-24 05:01:57 UTC
There's a bug in rubygems-1.0.1 that doesn't set the proper exitcode on failure, so the line in gems.eclass:

	gem install ${GEM_SRC} --version ${PV} ${myconf} \
		--local --install-dir "${D}/${GEMSDIR}" || die "gem install failed"

the die never gets called.

Filed an upstream bug at http://rubyforge.org/tracker/index.php?func=detail&aid=17438&group_id=126&atid=575
Comment 1 Marco Matthies 2008-02-17 13:28:24 UTC
Created attachment 143775 [details, diff]
work around the missing exit status until rubygems is fixed

This patch implements a work-around until rubygems is fixed. I'm probably not the world's best bash programmer, so comments are welcome!
Comment 2 Hans de Graaff gentoo-dev Security 2008-12-20 12:21:01 UTC
Closing this bug since dev-ruby/rubygems-1.0.1 is no longer in the tree, and this got fixed upstream, and consequently is fixed in all versions currently in the tree.

Josh, thanks for reporting it there.