Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 207067 - rox-extra/archive - fix dependencies
Summary: rox-extra/archive - fix dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Rox Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-22 18:13 UTC by Jakub Moc (RETIRED)
Modified: 2009-05-04 02:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
archive-2.1-r3.ebuild.diff (archive-2.1-r3.ebuild.diff,1.10 KB, patch)
2008-01-22 18:23 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2008-01-22 18:13:29 UTC
This pulls in tons for redundant deps due to missing || in RDEPEND. Patch attached.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2008-01-22 18:23:57 UTC
Created attachment 141594 [details, diff]
archive-2.1-r3.ebuild.diff

- add || for zip/rpm USE flags
- remove USE=bzip2, well you couldn't even unpack this without bzip2 :) 
- Removed virtual/gzip and app-arch/tar from RDEPEND, those are part of basic system and always installed.
Comment 2 Jim Ramsay (lack) (RETIRED) gentoo-dev 2008-01-22 19:33:50 UTC
Unfortunately these are not redundant dependencies:

- RPM support requires both 'rpm2cpio' from app-arch/rpm and then app-arch/cpio to finish unpacking the result.

- ZIP support uses app-arch/unzip to unzip, and app-arch/zip to create zip files.

Granted, RPM could (and I argue, should) use 'rpm2targz' instead, but I haven't bothered to write a patch that does this yet, since I don't use the RPM support.

Though I take your points about the USE flag and system dependencies, which I will clean up.
Comment 3 Jim Ramsay (lack) (RETIRED) gentoo-dev 2009-05-04 02:59:03 UTC
As fixed as it can be, anyway :)