Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 206815 - sys-power/hibernate-script auto network up and kde (xstatus) enhancement
Summary: sys-power/hibernate-script auto network up and kde (xstatus) enhancement
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Alon Bar-Lev (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-20 22:21 UTC by Pete Black
Modified: 2008-01-23 03:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
network auto up and kdialog fix (hibernate-script-1.97.patch,1.78 KB, patch)
2008-01-20 22:23 UTC, Pete Black
Details | Diff
network auto up and kdialog fix (hibernate-script-1.97.patch,1.78 KB, patch)
2008-01-20 22:29 UTC, Pete Black
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pete Black 2008-01-20 22:21:18 UTC
1. Only brings up interfaces that where brought down when using auto. Currently all interfaces will be brought up when resuming, even if they where down when hibernating.

2. Checks if KDE is running to avoid dcop timeout.

3. Adds the "kmenu" icon to KDialog (xstatus).

Reproducible: Always

Steps to Reproduce:
Hibernate with "DownInterfaces auto", "UpInterfaces auto" and "XStatus kde" set in common.conf

Actual Results:  
Notice missing icon in KDialog both during hibernation and resume.

After resume all interfaces will be brought up.

If KDE is not running you'll be forced to wait for the dcop call to timeout.

Expected Results:  
Some sort of icon in KDialog would be nice.

At resume, only those interfaces that where brought down should be brought back up when using auto.

If KDE is not running no need to wait for the dcop call to timeout.

Patch pending.
Comment 1 Pete Black 2008-01-20 22:23:50 UTC
Created attachment 141404 [details, diff]
network auto up and kdialog fix
Comment 2 Pete Black 2008-01-20 22:29:35 UTC
Created attachment 141405 [details, diff]
network auto up and kdialog fix

Got the dirs mixed up in the previous patch.
Comment 3 Alon Bar-Lev (RETIRED) gentoo-dev 2008-01-21 11:48:18 UTC
Hello,

Please submit this to upstream bugzilla... This is unrelated to Gentoo... If upstream accepts this, please open a bug here...

Just a few comments...
1. Split patches according to functionality, this patch should be splitted into three... One for networking, one for dcop and the other for kde icon. Each should have its own feature request bug at upstream.
2. By adding network_if_is_up only for Gentoo, you broke all none Gentoo distributions... This is not valid.
3. I am not sure the kde fix is needed, I remember some discussion about this in the past.
Comment 4 Pete Black 2008-01-23 03:37:59 UTC
(In reply to comment #3)
> Hello,

Hi Alon,

> Please submit this to upstream bugzilla... This is unrelated to Gentoo... If
> upstream accepts this, please open a bug here...

Done so, haven't heard back from anyone.

> Just a few comments...
> 1. Split patches according to functionality, this patch should be splitted into
> three... One for networking, one for dcop and the other for kde icon. Each
> should have its own feature request bug at upstream.

Yes, you're right.

> 2. By adding network_if_is_up only for Gentoo, you broke all none Gentoo
> distributions... This is not valid.

That's why i posted it here.

> 3. I am not sure the kde fix is needed, I remember some discussion about this
> in the past.

OK, I'll look in to that.

Appreciate your input. At least someone cares about the fine details ;)

Thanks,
Pete