Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 206645 - Checking that variables in the devmanual are quoted properly
Summary: Checking that variables in the devmanual are quoted properly
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-19 14:35 UTC by Petteri Räty (RETIRED)
Modified: 2008-01-24 04:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty (RETIRED) gentoo-dev 2008-01-19 14:35:54 UTC
http://devmanual.gentoo.org/ebuild-writing/functions/pkg_config/index.html

We should run a check similar to what repoman does currently to make sure that variables are quoted properly in devmanual.
Comment 1 Markus Meier gentoo-dev 2008-01-24 00:01:19 UTC
these are code examples which should be fixed. I found them with some grepping.

./ebuild-writing/functions/src_test/text.xml:62:    cd ${S}/src/testdir
./tools-reference/find/text.xml:76:find ${S} -type f | while read f ; do
./tools-reference/find/text.xml:91:for f in $(find ${S} -type f) ; do
./tools-reference/find/text.xml:110:find ${S} -name '*.backup' -exec rm '{}' \;
./tools-reference/sed/text.xml:53:    ${S}/plugin/ZoomWin.vim > ${S}/doc/ZoomWin.txt \
./tools-reference/sed/text.xml:56:sed -i -e '/^" HelpExtractor:$/,$d' ${S}/plugin/ZoomWin.vim \
./appendices/common-problems/text.xml:235:    ${S}/util/fluxbox-generate_menu -is -ds \

./archs/amd64/text.xml:466:    emake DESTDIR=${D} install || die

./ebuild-writing/functions/pkg_config/text.xml:52:    if [ ! -d ${ROOT}/var/lib/mysql/mysql ] ; then
./ebuild-writing/functions/pkg_config/text.xml:56:        ${ROOT}/usr/bin/mysql_install_db


I left out the text parts, like:
./general-concepts/install-destinations/text.xml:10:package in question from <c>${S}</c> into <c>${D}</c>. Ebuilds must <e>not</e> attempt to
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2008-01-24 04:26:43 UTC
Thanks.  I fixed all of these and committed it.  Reopen this if I missed anything or screwed up.

Thanks