Bug 206568 – x11-themes/gtk-engines-qt-0.8 autodetects libbonoboui, add gnome use flag

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Petteri Räty (RETIRED) 2008-01-18 19:55:15 UTC]

betelgeuse@pena ~ $ flame gtk-engines-qt
dev-libs/glib (/usr/lib/libglib-2.0.so.0)
dev-libs/glib (/usr/lib/libgobject-2.0.so.0)
gnome-base/libbonoboui (/usr/lib/libbonoboui-2.so.0)
sys-devel/gcc (/usr/lib/gcc/i686-pc-linux-gnu/4.2.2/libstdc++.so.6)
sys-libs/glibc (/lib/libc.so.6)
sys-libs/glibc (/lib/libm.so.6)
sys-libs/glibc (/lib/libpthread.so.0)
x11-libs/gtk+ (/usr/lib/libgdk_pixbuf-2.0.so.0)
x11-libs/gtk+ (/usr/lib/libgdk-x11-2.0.so.0)
x11-libs/gtk+ (/usr/lib/libgtk-x11-2.0.so.0)
x11-libs/libX11 (/usr/lib/libX11.so.6)
x11-libs/pango (/usr/lib/libpango-1.0.so.0)
x11-libs/qt (/usr/qt/3/lib/libqt-mt.so.3)

pena gtk-engines-qt # grep libbono *
pena gtk-engines-qt #

[Comment 1 Stefan Schweizer (RETIRED) 2008-01-19 13:56:40 UTC]

thnak you, added to depends

[Comment 2 Petteri Räty (RETIRED) 2008-01-19 14:22:40 UTC]

(In reply to comment #1)
> thnak you, added to depends
> 

The dep is optional so a gnome use flag would be the best solution.

[Comment 3 David Watzke 2008-01-19 14:39:12 UTC]

(In reply to comment #2)
> The dep is optional so a gnome use flag would be the best solution.

Yes, this is completely useless dep for a non-gnome user (pulls in 32 useless deps). I don't see any reason for adding a gnome USE-flag, though - it won't solve anything; if libbonoboui is found, then gtk-engines-qt will use it, otherwise not.

[Comment 4 Petteri Räty (RETIRED) 2008-01-19 14:51:43 UTC]

(In reply to comment #3)
> 
> Yes, this is completely useless dep for a non-gnome user (pulls in 32 useless
> deps). I don't see any reason for adding a gnome USE-flag, though - it won't
> solve anything; if libbonoboui is found, then gtk-engines-qt will use it,
> otherwise not.
> 

Autodetection breaks binary packages.

[Comment 5 David Watzke 2008-01-19 14:54:13 UTC]

(In reply to comment #4)> 
> Autodetection breaks binary packages.

It should be patched, then.

[Comment 6 Petteri Räty (RETIRED) 2008-01-19 15:05:12 UTC]

(In reply to comment #5)
> (In reply to comment #4)> 
> > Autodetection breaks binary packages.
> 
> It should be patched, then.
> 

Only if the build system doesn't support forcing settings.

[Comment 7 Wormo (RETIRED) 2008-08-14 06:58:22 UTC]

The build did need patching to allow explicit control of libbonoboui support; added in gtk-engines-qt-0.8-r3.ebuild

Note I'm not taking over this package despite a couple commits in a row, just taking up Stefan's suggestion for others to help out while he's away...