Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 206312 - dev-libs/newt-0.52.7: newt-0.52.7-DESTDIR.patch does not apply
Summary: dev-libs/newt-0.52.7: newt-0.52.7-DESTDIR.patch does not apply
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Christian Zoffoli (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-17 09:43 UTC by Martin von Gagern
Modified: 2008-01-18 17:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to newt-0.52.7-DESTDIR.patch (newt-0.52.7-DESTDIR.patch.patch,1.71 KB, patch)
2008-01-17 09:46 UTC, Martin von Gagern
Details | Diff
Same thing cleaned up (newt-0.52.7-DESTDIR.patch.patch,1.22 KB, patch)
2008-01-17 09:50 UTC, Martin von Gagern
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin von Gagern 2008-01-17 09:43:44 UTC
* Failed Patch: newt-0.52.7-DESTDIR.patch !
 *  ( /usr/portage/dev-libs/newt/files/newt-0.52.7-DESTDIR.patch )

I'll attach a patch to the patch, but probably a simple sed s/installroot/DESTDIR/g on Makefile.in would be a lot easier to maintain, and work just as well.
Comment 1 Martin von Gagern 2008-01-17 09:46:24 UTC
Created attachment 141114 [details, diff]
Patch to newt-0.52.7-DESTDIR.patch

The patch won't apply as my Makefile.in (straight from the tarball) has some lines mentioning $(WHIPTCLSO) in the vicinity of those changes that are not handled by the patch. The attached patch to the patch shows what would need to be modified in order to make the patch apply here.
Comment 2 Martin von Gagern 2008-01-17 09:50:00 UTC
Created attachment 141116 [details, diff]
Same thing cleaned up

Sorry, forgot to remove the first hunk which resulted from different file names on my system. More correctly I forgot to save after removing them. This is cleaner. Notice that the diff view of bugzilla seems to have problems with patches of patches, at least with the previous one. Let's see.
Comment 3 Christian Zoffoli (RETIRED) gentoo-dev 2008-01-18 15:19:55 UTC
I've not found any problem in my env. (probably is related to bug #206088), anyway I've added sed instead of the patch.

I'm waiting for you test to close the bug.
Comment 4 Martin von Gagern 2008-01-18 16:58:45 UTC
(In reply to comment #3)
> I've not found any problem in my env. (probably is related to bug #206088),
> anyway I've added sed instead of the patch.
> 
> I'm waiting for you test to close the bug.

It's related: the notcl patch interfers. Current ebuild emerges file. Thanks!
Comment 5 Christian Zoffoli (RETIRED) gentoo-dev 2008-01-18 17:45:20 UTC
...closing