Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 206273 - app-text/gtkspell: - add noenchant use flag
Summary: app-text/gtkspell: - add noenchant use flag
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest enhancement
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-16 23:50 UTC by Grimpy Reaper
Modified: 2008-03-06 23:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
added useflag noenchant (gtkspell-2.0.11-r2.ebuild,1.18 KB, text/plain)
2008-01-16 23:51 UTC, Grimpy Reaper
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Grimpy Reaper 2008-01-16 23:50:37 UTC
app-text/gtkspell: autopatch with enchant instead of useflag should better have a useflag for applying this patch as sometimes this isnt wanted

Reproducible: Always
Comment 1 Grimpy Reaper 2008-01-16 23:51:39 UTC
Created attachment 141086 [details]
added useflag noenchant
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-01-17 14:41:29 UTC
nouse flags are not shiny, use IUSE defaults.
Other than that, this patch is here to make gtkspell use an abstration layer (enchant) rather than directly using ${PREFERED_SPELLCHECK} directly. I feel this is better this way so I won't change it.

@herd what do you guys think ?
Comment 3 Grimpy Reaper 2008-01-17 17:52:01 UTC
(In reply to comment #2)
> nouse flags are not shiny, use IUSE defaults.
> Other than that, this patch is here to make gtkspell use an abstration layer
> (enchant) rather than directly using ${PREFERED_SPELLCHECK} directly. I feel
> this is better this way so I won't change it.
> 
> @herd what do you guys think ?
> 

I agree with u that in almost every case it would be better that way, thats why I made a noenchant useflag inestead of a enchant useflag. But in my case specificly i would likt to call some specefic aspell calls through it so i dont wont the enchant patch
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2008-01-18 07:21:25 UTC
I'm not exactly thrilled about making this patch optional. I'd say this is simple enough to keep it in an overlay outside portage.
Comment 5 Daniel Gryniewicz (RETIRED) gentoo-dev 2008-02-14 04:28:13 UTC
Is there an actual advantage to calling aspell directly?
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-03-06 23:15:32 UTC
please provide convincing arguments that would justify the extra work of allowing this and we will consider. Closing wontfix for now.