205781 – stardict.eclass - unsafe locale-dependent patterns usage

Bug 205781 - stardict.eclass - unsafe locale-dependent patterns usage

Summary: stardict.eclass - unsafe locale-dependent patterns usage

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	CJK Team

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:

Reported:	2008-01-14 12:16 UTC by Jakub Moc (RETIRED)
Modified:	2008-03-27 13:59 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jakub Moc (RETIRED) gentoo-dev

2008-01-14 12:16:35 UTC

-[ -z "${DICT_SUFFIX}" ] && DICT_SUFFIX=${PN#stardict-[a-z]*-}
+[ -z "${DICT_SUFFIX}" ] && DICT_SUFFIX=${PN#stardict-[:lower:]*-}

is probably what you want.

Comment 1 Peter Volkov (RETIRED) gentoo-dev

2008-02-25 14:50:52 UTC

jakub, could you remind, please. How to break [a-z] code?

Comment 2 Jakub Moc (RETIRED) gentoo-dev

2008-02-25 17:32:14 UTC

(In reply to comment #1)
> jakub, could you remind, please. How to break [a-z] code?

Yeah sure; set your locales to Estonian and watch the phun. There's loads of bugs about this in bugzilla.

Comment 3 Mark Loeser (RETIRED) gentoo-dev

2008-03-27 02:31:39 UTC

I'll go ahead and fix this in the next day or so unless someone does so before me (or screams no) :)

Comment 4 Peter Volkov (RETIRED) gentoo-dev

2008-03-27 13:59:01 UTC

Fixed in the tree together with bug 163833.