As (I think) Obeliks said on IRC, this line is missing a "${5}" parameter _java-osgi_makejar "${1}" "${3}" "${4}" And I noticed that the @example has last two params in different order than in the actual jsch ebuild :) Which is it? # @example # java-osgi_newjar "dist/${PN}.jar" "com.jcraft.jsch" "com.jcraft.jsch, com.jcraft.jsch.jce;x-internal:=true" "JSch" Rather trivial fix, the reason I fill this bug is that it looks weird to handle parameters like this, with second being optional, I would probably move it as the last parameter which would simplify the function. But I understand that it's as second param because of what normal newjar() does. So we should decide together.
Yes, this is a trivial fix. Regarding the @example, it is wrong, the actual jsch ebuild is right, eg, "com.jcraft.jsch,com.jcraft.jsch.jce;x-internal:=true" is the export header. Regarding the handling of parameters, I agree it is a bit weird, as you pointed out I did that because of what newjar does. Meet on IRC to discuss if you don't like it.
I commited the fix. Shall I close the bug, or leave it open for discussion?
OK let's close.
