Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 204912 - regression in ecopy after linux keyword change
Summary: regression in ecopy after linux keyword change
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo non-Linux Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-08 15:57 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified: 2008-01-08 19:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-01-08 15:57:14 UTC
line 43:
-ekeyword ~$ACCEPT_KEYWORDS $ebuild
+ekeyword $ACCEPT_KEYWORDS $ebuild

Reason: line 42[1] now returns ~x86-linux instead of x86-linux so ekeyword doesn't understand ~~x86-linux.


[1]: source "${EPREFIX:-$(portageq envvar EPREFIX)}"/etc/make.profile/make.defaults
Comment 1 Fabian Groffen gentoo-dev 2008-01-08 17:05:31 UTC
could you try out revision 15087?
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-01-08 18:45:45 UTC
(In reply to comment #1)
> could you try out revision 15087?

% source "${EPREFIX:-$(portageq envvar EPREFIX)}"/etc/make.profile/make.defaults
% echo "~${ACCEPT_KEYWORDS#~}" #r15087
~~x86-linux
% echo "${ACCEPT_KEYWORDS#~}"  # I think this is what you want
~x86-linux

I think you want the last one, yes? Not the first one because that creates a double ~~ which ekeyword doesn't understand.
Comment 3 Fabian Groffen gentoo-dev 2008-01-08 18:50:56 UTC
did you try it?

We still want ~arch keywords.

${ACCEPT_KEYWORDS#~} means strip off a leading ~ if any, unless I screwed it up ;)

I wasn't sure, so backwards_compatibility++
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-01-08 18:55:35 UTC
(In reply to comment #3)
> did you try it?

Of course, still failed.

> We still want ~arch keywords.

Obviously.

> ${ACCEPT_KEYWORDS#~} means strip off a leading ~ if any, unless I screwed it up

You screwed it up. 

I'm not sure of the bash expansion needed here but what you provided doesn't strip off the leading ~, it just doesn't expand to a single ~.

IF ACCEPT_KEYWORDS=~ then "~${ACCEPT_KEYWORDS#~}" prints a lone ~ because a ~ is in front of the $. "${ACCEPT_KEYWORDS#~}" prints nothing. Try it out.
Comment 5 Fabian Groffen gentoo-dev 2008-01-08 19:01:17 UTC
I the h@ck screwed it up indeed ///1P!LL

Try out 15088

(tested this time)
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-01-08 19:06:26 UTC
(In reply to comment #5)
> I the h@ck screwed it up indeed ///1P!LL
> 
> Try out 15088
> 
> (tested this time)

Yup, looks good this time. Works too =)

Question: Will the profile ever set ACCEPT_KEYWORDS to be '~' - I'm am unclear why it can't just be $ACCEPT_KEYWORDS and forget about stripping the leading ~ then adding it back.
Comment 7 Fabian Groffen gentoo-dev 2008-01-08 19:08:49 UTC
I only yesterday changed all profiles, so technically it shouldn't be necessary, but people tend to have the most weird setups, so in order not to break...