Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 20488 - Updates to policy guide
Summary: Updates to policy guide
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs-developer
Classification: Unclassified
Component: Documentation Developer Policy (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Docs Team
URL:
Whiteboard:
Keywords:
: 20138 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-05-05 12:06 UTC by Jon Portnoy (RETIRED)
Modified: 2003-06-05 21:06 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Diff of changes (policy.diff,24.85 KB, patch)
2003-05-05 12:07 UTC, Jon Portnoy (RETIRED)
Details | Diff
Full modified policy guide (policy.xml,22.40 KB, text/plain)
2003-05-05 12:09 UTC, Jon Portnoy (RETIRED)
Details
Full modified doc updated May 14th 03 (policy.xml,22.55 KB, text/plain)
2003-05-14 17:20 UTC, Jon Portnoy (RETIRED)
Details
Updated diff of changes (policy-20030514.diff,25.65 KB, patch)
2003-05-14 17:21 UTC, Jon Portnoy (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Portnoy (RETIRED) gentoo-dev 2003-05-05 12:06:37 UTC
This merges vapier's changes with mine and adds sections covering various
QA-related things. There are also code cleanups, 99.5% of them from vapier.

I'm posting a diff against the old one and the complete altered document. Please
comment.
Comment 1 Jon Portnoy (RETIRED) gentoo-dev 2003-05-05 12:07:47 UTC
Created attachment 11529 [details, diff]
Diff of changes
Comment 2 Jon Portnoy (RETIRED) gentoo-dev 2003-05-05 12:09:02 UTC
Created attachment 11530 [details]
Full modified policy guide
Comment 3 Jon Portnoy (RETIRED) gentoo-dev 2003-05-05 12:22:27 UTC
Carl or peesh - could you please proofread this?
Comment 4 Carl Anderson (RETIRED) gentoo-dev 2003-05-05 12:52:15 UTC
Yes, I'll proof it.  I'll check it over in a few minutes.
Comment 5 Carl Anderson (RETIRED) gentoo-dev 2003-05-05 13:32:03 UTC
I'm going off of the diff here, so I'm going to assume that all sections not modified are okay.  However, I'm still reading those for consistency sake.
-----

PROBLEM WITH NOUN/VERB AGREEMENT
"Be cautious about what you commit. Remember that your commits can potentially harm thousands of users. If your commits cause any breakage in the tree, it must be fixed in a timely fashion."

This should be "If your COMMIT CAUSES any breakage in the tree, it must ..." or "If your commits cause any breakage in the tree, THEY must ..."

WORD ORDER
"The first pkg section ..." and "The second ver section ..." imply that there are multiple "X" sections.  These should read "The first section, pkg, ..." and "The second section, ver, ..." and so on through the document.

LIST ORDER
In the suffix table, I'd move the "normal" row to the last spot, moving the patch level up one.

USE OF COMMAS
The use of commas should be properly done anywhere there is an example given prefaced by "e.g.".  In most cases, I would use a semicolon rather than a comma; e.g., this sentence.  Then again, the rules of English say that the phrase offset by a semicolon should be a complete sentence; perhaps a colon (:) would be more appropriate here.  In any case, a comma doesn't work.

PARAGRAPH CONSTRUCTION
The "Virtuals" section contains an early example with a virtual package named "foocron."  I would more the section beginning with the sentence "Here's an example on how ..." to a new paragraph.  It gets rather lost otherwise.

SENTENCE CONSTRUCTION
At the end of the "Virtuals" section, the word "virtuals" is a bit overused.  Change

"Keeping developers informed of new virtuals is essential to ensure uniform use of virtuals" to

"Keeping developers informed of new virtuals is essential to ensure their uniform use."

CAPITALIZATION
In the CVS section, there is a sentence that reads:

"live" <path>cvs.eclass</path> ebuilds are generally only intended for the ..."

Since the "live" part is not a brand name, trademark, proper name, or otherwise, I think it should be capitalized in this case.  sendmail can get away with a lowercase "S" at the beginning of a sentence; "live" cannot.

SPELLING MISTAKE
At the end of the user ebuild section, "an" is used where "and" is correct:

"...be a skilled an productive member of our project in the future..."

should be

"...be a skilled AND productive member of our project in the future..."

STYLE AND FORMATTING
The masked packages section contains several paths to files--shouldn't they be in <path></path> notation?

-----

I'll leave it to you to make sure the XML is valid.  Otherwise, everything looks pretty good.  Nice job!
Comment 6 Jon Portnoy (RETIRED) gentoo-dev 2003-05-05 16:28:26 UTC
*** Bug 20138 has been marked as a duplicate of this bug. ***
Comment 7 Patrick Kursawe (RETIRED) gentoo-dev 2003-05-08 01:52:05 UTC
The hint about discussing virtuals before introducing them seems to be necessary... I did that yesterday after just asking on #gentoo-dev, shame on me.
Comment 8 Jon Portnoy (RETIRED) gentoo-dev 2003-05-09 13:53:57 UTC
If nobody disagrees, I'll also add a section on local USE vars going into use.local.desc.

Expect an updated version with Carl's fixes and the section mentioned before tomorrow.

Thanks folks.
Comment 9 Jon Portnoy (RETIRED) gentoo-dev 2003-05-14 17:20:02 UTC
Created attachment 11988 [details]
Full modified doc updated May 14th 03

Updated with all of Carl's fixes - thanks Carl!

If there are no complaints within a few days, could a docs person please put
this up?
Comment 10 Jon Portnoy (RETIRED) gentoo-dev 2003-05-14 17:21:48 UTC
Created attachment 11989 [details, diff]
Updated diff of changes
Comment 11 Jon Portnoy (RETIRED) gentoo-dev 2003-06-05 21:06:16 UTC
zhen put this up recently. Thanks zhen!