Newly merged L2TP stack in Linux 2.6.23 kernel breaks any package that depends on linux/if_ppp* headers, f.ex. rp-pppoe does. Reproducible: Always Steps to Reproduce: This microtest is derived from what rp-pppoe build system experiencing: #include <sys/socket.h> #include <net/ethernet.h> #include <linux/if.h> #include <linux/if_ppp.h> #include <linux/if_pppox.h> int main(void) { return 0; } Actual Results: shade@1608-pegasus ~/pppoe/sample $ gcc pppoe-try.c -o pppoe-try In file included from /usr/include/linux/if_pppox.h:26, from pppoe-try.c:4: /usr/include/linux/if_pppol2tp.h:30: error: field ‘addr’ has incomplete type Expected Results: shade@1608-pegasus ~/pppoe/sample $ gcc pppoe-try.c -o pppoe-try
Created attachment 140194 [details, diff] Proposed patch This patch for gentoo-headers solves the problem. There's a need to consult with kernel hackers how exactly this patch must sound like.
Uh, please stop using net-dialup/rp-pppoe for anything. Been deprecated ages ago in favour of ppp and baselayout. http://www.gentoo.org/doc/en/handbook/handbook-x86.xml?part=4&chap=3#doc_chap4
[OT] Thanks, Jakub. Unfortunately, there is a need in working PPPoE _server_. AFAIU, your suggestion covers only client-side PPPoE. [/OT] Anyway, this issue affect not only the net-dialup/rp-pppoe but any other package depending on mentioned headers.
yeah, dont pay attention to him ... the changes you propose look like a good direction, but you're right that we'll have to post it to lkml and see how others like it
> but you're right that we'll have to post it to lkml and see how others like it Ok, should I do that myself, or there is any working process for migrating such the issues to lkml?
i'll post an update later tonight (hopefully)
SpanKY, any updates?
should be fixed with 2.6.24 headers please test
The issue disappeared for this microtest on linux-headers-2.6.24 ...but rp-pppoe compilation fails on another issue. I will open new bug on that.
