Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 203987 - /usr/bin/rox script should specify bash, not /bin/sh
Summary: /usr/bin/rox script should specify bash, not /bin/sh
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Rox Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-01-01 19:41 UTC by Hopeless
Modified: 2008-01-02 13:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
change to #!/bin/bash (rox-2.6.1.ebuild.patch,309 bytes, patch)
2008-01-01 19:49 UTC, Hopeless
Details | Diff
rox-sh.patch (rox-sh.patch,496 bytes, patch)
2008-01-01 20:12 UTC, Santiago M. Mola (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hopeless 2008-01-01 19:41:36 UTC
I have /bin/sh symlinked to dash (a posix shell) rather than bash, and upon starting rox I get the following in the shell, although rox-filer starts fine;
    /usr/bin/rox: 6: [[: not found
    /usr/bin/rox: 12: [[: not found

Replacing the #!/bin/sh with #!/bin/bash resolves the issue.

I know this is extremely trivial, not likely to be encountered by very many and most likely an upstream issue anyway, so feel free to mark as invalid, upstream or whatever.


Reproducible: Always
Comment 1 Hopeless 2008-01-01 19:49:52 UTC
Created attachment 139808 [details, diff]
change to #!/bin/bash

Scratch what I just said about this being upstream, I checked in rox-base/rox/files/ for the script, but I didn't realise it was actually part of the ebuild itself.

Here's a patch to the ebuild (rox-2.6.1.ebuild) to change it to /bin/bash, although it'd probably be easier to do it by hand.
Comment 2 Santiago M. Mola (RETIRED) gentoo-dev 2008-01-01 20:12:40 UTC
Created attachment 139809 [details, diff]
rox-sh.patch

Or make it POSIX-sh compatible.
Comment 3 Jim Ramsay (lack) (RETIRED) gentoo-dev 2008-01-02 13:22:24 UTC
Thanks!  Made this (and everything wrapped in the rox.eclass too, which suffered from the same problem) POSIX compliant.