Inside [ ] you cannot correctly check return values of commands. Use: if ! has_version x11-libs/qt-core || ! built_with_use x11-libs/qt-core ssl ; ... if ! has_version x11-libs/qt-sql || ! built_with_use x11-libs/qt-sql sqlite ; Also consistently use [[ ]] instead of [ ] when checking variables: elif [[ ${x} == ssl ]]; then ... elif [[ ${x} == sqlite3 ]]; then (Also note that [ ] uses -a / -o instead of && / ||.)
I won't be able to fix until tomorrow, so if someone can stab it before then feel free.
do you have a patch you can supply on fixing this?
Created attachment 140215 [details, diff] Patch
thanks a bunch, just committed.
The patch has an error in it. The last updated line has "\ instead of \" immediately before the word sqlite, resulting in syntax errors.
(In reply to comment #5) > The patch has an error in it. No. The attached patch was correct. Somebody introduced this error after application of this patch. > The last updated line has "\ instead of \" > immediately before the word sqlite, resulting in syntax errors. Somebody fixed it: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/qt4.eclass?r1=1.32&r2=1.33&sortby=date
I'm reading http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/qt4.eclass?r1=1.31&r2=1.33&sortby=date&diff_format=u and I see another mistake. My patch contained: die "Install x11-libs/qt-core with USE=\"ssl\"" But Caleb Tennis committed: die "Install x1-libs/qt-core with USE=\"ssl\"" I think that it should be fixed.
sorry ,was working via a shell window on a remote machine and I suppose that's what happens when you type faster than the connection would handle :)
