Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 203514 - games-puzzle/tetrinet: Proper fix for IPv6 compilation error
Summary: games-puzzle/tetrinet: Proper fix for IPv6 compilation error
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High minor
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-27 20:51 UTC by Andrew Church
Modified: 2008-01-15 10:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Proposed ebuild patch (tetrinet-no-ipv6-fix.patch,3.59 KB, patch)
2007-12-27 20:51 UTC, Andrew Church 		Details | Diff
Proposed patch without extra junk (tetrinet-no-ipv6-fix.patch,1.06 KB, patch)
2007-12-27 20:55 UTC, Andrew Church 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Church 2007-12-27 20:51:26 UTC 
Bug 32860 forces IPv6 support on regardless of the state of the ipv6 USE flag due to a compilation error (rather embarrassing, since the error was mine).  The proper fix is to patch the source:

--- ../tetrinet-0.11-orig/sockets.c     2003-09-10 04:15:04 +0900
+++ sockets.c   2007-12-28 05:35:49 +0900
@@ -188,7 +188,7 @@
        return -1;
     }
     if (ipbuf)
-       memcpy(retbuf, &sa.sin_addr, 4);
+       memcpy(ipbuf, &sa.sin_addr, 4);
 #endif
 
     return sock;
Comment 1 Andrew Church 2007-12-27 20:51:52 UTC 
Created attachment 139461 [details, diff]
Proposed ebuild patch
Comment 2 Andrew Church 2007-12-27 20:55:05 UTC 
Created attachment 139462 [details, diff]
Proposed patch without extra junk

Oops!  Didn't mean to include the Manifest junk in there...
Comment 3 Tristan Heaven (RETIRED) gentoo-dev 2008-01-15 10:27:25 UTC 
Fixed, thanks.