Bug 203416 – [PATCH] sys-kernel/gentoo-sources-2.6.23*: ip_gre: set mac_header correctly in receive path

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Natanael Copa 2007-12-27 07:24:37 UTC]

recvfrom() does not work correctly on gre interfaces.

[Comment 1 Natanael Copa 2007-12-27 07:26:15 UTC]

Created attachment 139384 [details, diff]
[IPV4] ip_gre: set mac_header correctly in receive path

Makes recvfrom() work correctly on gre interfaces. Needed for NAT detection in opennhrp (http://sourceforge.net/projects/opennhrp)

Patch is in Linus tree for 2.6.24 inclusion.

[Comment 2 Natanael Copa 2007-12-27 07:30:23 UTC]

This is a fix for #196904

[Comment 3 Natanael Copa 2007-12-27 08:05:42 UTC]

(In reply to comment #2)
> This is a fix for #196904
> 

Let me rephrase this. This is a tiny fix for a previous patch posted in #196904.

Should probably go into the 2.6.22 branch as well.

[Comment 4 Mike Pagano 2007-12-29 13:15:55 UTC]

This patch applies and compiles against gentoo-sources-2.6.23-r5 and gentoo-sources-2.6.22-r10

Tristan, have you/can you confirm that the patch applied against both of the gentoo-sources versions described above fixes the problem and appears to work properly.

Please post the results here.

[Comment 5 Daniel Drake (RETIRED) 2007-12-29 13:47:47 UTC]

No need to test 2.6.22, we won't be doing further releases there

[Comment 6 Mike Pagano 2008-01-16 00:18:07 UTC]

Tristan, any progress testing this patch against gentoo-sources-2.6.23-r5?

[Comment 7 Natanael Copa 2008-01-16 15:49:37 UTC]

this one is in 2.6.23.y queue already. (and 2.6.22 too actually)

http://git.kernel.org/?p=linux/kernel/git/stable/stable-queue.git;a=blob;f=queue-2.6.23/ipv4-ip_gre-set-mac_header-correctly-in-receive-path.patch;h=19a1e00bee4f0d56e1103e9ae30e32f4ec57be2a;hb=master

I guess we can just close this and wait for next 2.6.23.y release.

Thanks!