Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 203225 - net-dialup/minicom - add USE="nls"
Summary: net-dialup/minicom - add USE="nls"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-24 13:17 UTC by Andrew Church
Modified: 2007-12-27 09:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed ebuild (minicom-2.2-r2.ebuild,1.21 KB, text/plain)
2007-12-24 13:21 UTC, Andrew Church
Details
Patch against minicom-2.2-r1.ebuild (minicom-2.2-r1.ebuild.patch,759 bytes, patch)
2007-12-24 13:54 UTC, Andrew Church
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Church 2007-12-24 13:17:30 UTC
net-dialup/minicom-2.2-r1 installs its locale files regardless of the state of the nls USE flag.  (Suggested fix forthcoming.)
Comment 1 Andrew Church 2007-12-24 13:21:57 UTC
Created attachment 139251 [details]
Proposed ebuild

This ebuild adds $(use_enable nls) to the configure invocation, to prevent locale files from being installed if !nls.  I've also added a conditional build dependency on gettext (if nls), along the lines of other localized packages like coreutils.
Comment 2 Andrew Church 2007-12-24 13:54:32 UTC
Created attachment 139253 [details, diff]
Patch against minicom-2.2-r1.ebuild

Sorry, is it better to post a diff against the existing ebuild?  (Also, was it proper of me to add ~ to the keywords in the diff?)
Comment 3 Alin Năstac (RETIRED) gentoo-dev 2007-12-27 09:19:41 UTC
Yes, a patch is preferred because it is easier to review.
  
Fixed without revision bump since package will be re-emerged by -N option. In addition, I've added supported LINGUAS to IUSE.