Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 203069 - app-text/bibletime-1.5.3 installs bad desktop file
Summary: app-text/bibletime-1.5.3 installs bad desktop file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Theology Herd (disbanded)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-22 20:35 UTC by Thomas Anderson (tanderson) (RETIRED)
Modified: 2008-02-19 16:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
fix bibletime.desktop patch (diff,469 bytes, patch)
2007-12-22 20:37 UTC, Thomas Anderson (tanderson) (RETIRED) 		Details | Diff
Ebuild patch for bibletime (bibletime-ebuild.patch,298 bytes, patch)
2008-01-10 17:26 UTC, Thomas Anderson (tanderson) (RETIRED) 		Details | Diff
Patch to bibletime.desktop (bibletime-1.6.5-fixdesktop.patch,723 bytes, patch)
2008-01-10 17:27 UTC, Thomas Anderson (tanderson) (RETIRED) 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-12-22 20:35:58 UTC 
When merging I see:

 * /usr/share/applications/kde/bibletime.desktop: value "bibletime.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path -- value "Religion;Bible;Application;KDE;Utility;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Religion"; values extending the format should start with "X-" -- value "Religion;Bible;Application;KDE;Utility;" for key "Categories" in group "Desktop Entry" contains an unregistered value "Bible"; values extending the format should start with "X-"

This is bad. I'll attach a patch to fix the desktop file shortly.

Reproducible: Always
Comment 1 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-12-22 20:37:19 UTC 
Created attachment 139129 [details, diff]
fix bibletime.desktop patch
Comment 2 Steve Dibb (RETIRED) gentoo-dev 2008-01-10 00:18:40 UTC 
Can you look at it for latest bibletime (1.6.5)?
Comment 3 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2008-01-10 17:26:08 UTC 
Created attachment 140611 [details, diff]
Ebuild patch for bibletime

Patch for bibletime-1.6.5.ebuild. This is reworked to use a patch rather than sed hackery.
Comment 4 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2008-01-10 17:27:11 UTC 
Created attachment 140613 [details, diff]
Patch to bibletime.desktop
Comment 5 Steve Dibb (RETIRED) gentoo-dev 2008-02-19 16:11:30 UTC 
in CVS, bibletime-1.6.5-r1