The vanilla DC++ and linuxdcpp file lists aren't compatible with older clients', since the file list format was changed. Other clients offer backwards compatibility (Valknut does, afaik). A friend of mine created a patch that fixes this, based on a older version of the core, that was still compatible. Reproducible: Always Steps to Reproduce: 1.try to download a file list from a user running older clients (e.g oDC) 2.it will fail Expected Results: it should download the file list
Created attachment 138376 [details, diff] linuxdcpp_support_odc.patch this patch can be applied against linuxdcpp 1.0.0*
Thanks, but Gentoo bugzilla is not the right place to file similar requests; please ask upstream to include this. Thanks. http://developer.berlios.de/bugs/?group_id=2230
(In reply to comment #2) > Thanks, but Gentoo bugzilla is not the right place to file similar requests; > please ask upstream to include this. Thanks. > > http://developer.berlios.de/bugs/?group_id=2230 > Hello, AFAIK they removed the support on purpose, since this was included in the older releases. Anyway, I'll post it upstream too, but my intention was to have this patch applied by default by our ebuild, and based on a "vanilla" USE-flag it could be disabled by anyone who doesn't need it. I think it would be nice to have it, because most of the networks have 90% or more users with older clients, that the vanilla linuxdcpp is incompatible with, and this patch would fix that issue. Best regards, Cristi
(In reply to comment #3) > AFAIK they removed the support on purpose, since this was included in the older Well, for stuff removed on purpose, it's upstream decision which we shouldn't revert unless we're going to fork the thing. :) Saves us all kind of trouble when reporting bugs upstream.
(In reply to comment #4) > Well, for stuff removed on purpose, it's upstream decision which we shouldn't > revert unless we're going to fork the thing. :) Saves us all kind of trouble > when reporting bugs upstream. Good point, but we could ewarn the users that it's a patched version and not to post bugs/ask for support to the upstream unless the program was recompiled with the vanilla USE-flag enabled, and they were still able to reproduce the bug. Anyway, I've posted a bug in the upstream's bugtracker asking them to apply the patch, but i kind of doubt they will. Cristi
I got this answer from one of the linuxdcpp developers: Should probably have commented this on the gentoo bugzilla, but I'm just lazy enough to not to create an account there. For this to be accepted for LinuxDC++ it should be included in the windows client also, as the patch modifies the client/ -part and we try to keep it in sync with the windows client. ... So maybe you want to try the upstream and send the patch to them... (ok, just kidding. I doubt they would accept it as the support was removed for a reason) Also adding this would probably upset the fake client detectors, as the client is claiming to be 0.698 and still accepts/sends old style lists.. --RZ PS. You should find better hubs if there are 90% of old clients... So it seems we are dealing with 2 upstreams... Cristi
