Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 202007 - sci-electronics/kicad has an obsolete check for gtk2 useflag
Summary: sci-electronics/kicad has an obsolete check for gtk2 useflag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: The Soldering-Iron Brotherhood
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-12 03:16 UTC by Denilson Sá Maia
Modified: 2007-12-12 11:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Denilson Sá Maia 2007-12-12 03:16:47 UTC
All current sci-electronics/kicad ebuilds have the following check inside an if-else statement:

need-wxwidgets gtk2 || die "You need to install wxGTK with gtk2 support."

There is no gtk2 flag anymore. I don't know if this check should be replaced by an updated one or just removed. (and my system has the unicode flag set, rebuilding wxGTK without it just to test this ebuild would take to much time from my no-so-fast machine)

[off-topic -- yeah, I know I shouldn't use one bug for more than one thing]
By the way, looks like the latest version at the site is 29 nov 2007, while at the portage it is 20070702.
http://iut-tice.ujf-grenoble.fr/cao/version.txt
Comment 1 Denis Dupeyron (RETIRED) gentoo-dev 2007-12-12 09:28:40 UTC
(In reply to comment #0)
> All current sci-electronics/kicad ebuilds have the following check inside an
> if-else statement:
> 
> need-wxwidgets gtk2 || die "You need to install wxGTK with gtk2 support."
> 
> There is no gtk2 flag anymore. I don't know if this check should be replaced by
> an updated one or just removed. (and my system has the unicode flag set,
> rebuilding wxGTK without it just to test this ebuild would take to much time
> from my no-so-fast machine)

The gtk2 dependency is apparently now automatically triggered by the X USE flag. I have fixed that. Thanks for noticing it.

> [off-topic -- yeah, I know I shouldn't use one bug for more than one thing]
> By the way, looks like the latest version at the site is 29 nov 2007, while at
> the portage it is 20070702.
> http://iut-tice.ujf-grenoble.fr/cao/version.txt

kicad-2007-11-29-RC2 is a release candidate, as its name implies. On top of that, upstream have changed their development process a lot since the previous release, so you want to be doubly careful here. And finally, since kicad supports wxGTK-2.6 less and less, I'll introduce the new versions for wxGTK-2.8 only and it is still hard masked.

All that means there's no way you'll get that particular version in our tree. I will do my best to have the new final release ASAP after it's released, but since the ebuild is in dire need of a full rewrite (and kicad is a big mess that is currently hidden by the custom tarball I make for each release) you'll need to be patient.

Denis.
Comment 2 Mart Raudsepp gentoo-dev 2007-12-12 11:08:19 UTC
In coordinate with Denis, I touched it up to use need-wxwidgets as expected by the wxwidgets.eclass nowadays, so now USE=-unicode should work right and not fail after the last changes. The die messages are removed because need-wxwidgets takes care of it with the correct and sufficiently verbose message, saying exactly what is the problem. need-wxwidgets asks for a certain wxGTK configuration, not USE flags used on it.


diff -u -B -r1.3 kicad-20070702.ebuild
--- kicad-20070702.ebuild       12 Dec 2007 09:17:27 -0000      1.3
+++ kicad-20070702.ebuild       12 Dec 2007 11:07:13 -0000
@@ -21,11 +21,11 @@
        # Tell wxwidgets.eclass which version we need
        WX_GTK_VER="2.6"
 
-       # Check for proper wxGTK USE flags.
+       # Ask for the correct wxGTK configuration
        if use unicode; then
-               need-wxwidgets unicode || die "You need to install wxGTK with unicode support."
+               need-wxwidgets unicode
        else
-               need-wxwidgets X || die "You need to install wxGTK with X support."
+               need-wxwidgets ansi
        fi
        built_with_use "=x11-libs/wxGTK-${WX_GTK_VER}*" opengl || die "You need to install wxGTK with opengl support."
 }