Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 201544 - dev-util/git: `tk' USE flag is broken
Summary: dev-util/git: `tk' USE flag is broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: AMD64 Linux
: Low minor
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-07 00:25 UTC by Elvis Pranskevichus
Modified: 2007-12-25 08:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Use NO_TCLTK git Makefile option to disable Tcl/Tk parts (git-1.5.3.7-r2.ebuild.diff,571 bytes, patch)
2007-12-07 00:26 UTC, Elvis Pranskevichus 		Details | Diff
Should be against 1.5.3.7-r1 of course. (git-1.5.3.7-r1.ebuild.diff,576 bytes, patch)
2007-12-07 00:32 UTC, Elvis Pranskevichus 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elvis Pranskevichus 2007-12-07 00:25:56 UTC 
Current git ebuild interprets USE=-tk as:

use tk || rm "${D}"/usr/bin/git{k,-gui}

Which is incorrect for two reasons:

1) It leaves a lot of stuff in /usr/share/git-gui
2) Since 1.5.2 git has NO_TCLTK make option to correctly disable tk-dependent parts.
Comment 1 Elvis Pranskevichus 2007-12-07 00:26:57 UTC 
Created attachment 137928 [details, diff]
Use NO_TCLTK git Makefile option to disable Tcl/Tk parts
Comment 2 Elvis Pranskevichus 2007-12-07 00:32:02 UTC 
Created attachment 137930 [details, diff]
Should be against 1.5.3.7-r1 of course.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-12-25 08:58:28 UTC 
in cvs.