Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 201087 - eutils.eclass: epatch fails if PORTAGE_TMPDIR contains whitespace
Summary: eutils.eclass: epatch fails if PORTAGE_TMPDIR contains whitespace
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-03 12:00 UTC by Ulrich Müller
Modified: 2010-01-09 20:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,7.56 KB, text/plain)
2007-12-03 12:01 UTC, Ulrich Müller
Details
eutils-epatch.eclass (eutils-epatch.eclass,5.28 KB, text/plain)
2009-12-09 08:07 UTC, SpanKY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2007-12-03 12:00:14 UTC
Setting PORTAGE_TMPDIR to "/var/tmp/my funny tmpdir" makes epatch fail miserably, see attached build.log. Line 1751 in temp/environment corresponds to the line:
    for x in ${EPATCH_SOURCE}
in function epatch.

Also diefunc() seems to have some problems of its own.
Comment 1 Ulrich Müller gentoo-dev 2007-12-03 12:01:04 UTC
Created attachment 137611 [details]
build.log
Comment 2 SpanKY gentoo-dev 2007-12-04 19:14:35 UTC
the lack of whitespace around EPATCH_SOURCE is to allow for wildcards ... but we'll have to split up the logic into separate variables to account for whitespace
Comment 3 SpanKY gentoo-dev 2009-12-09 08:07:31 UTC
Created attachment 212514 [details]
eutils-epatch.eclass

i wanted to fix something in epatch related to logging and it ended up being easier to rewrite it; by that point, i might as well rewrite the whole thing and fix a whole bunch of things that have always annoyed me; by *that* point, i might as well fix this bug too

no diff since pretty much every line has changed.  i'll commit if i dont notice breakage on my machine for a little while
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2009-12-09 19:52:31 UTC
A quick review reveals no insanity.
Comment 5 SpanKY gentoo-dev 2010-01-09 20:07:29 UTC
committed then after a few more tweaks

http://sources.gentoo.org/eclass/eutils.eclass?r1=1.324&r2=1.325