Using vorbisgain on FAT produces (normal) errors on files access but improper use of errno leads to stop on directory recursion. Reproducible: Always Steps to Reproduce: 1. vorbisgain -arfs on directory that contains ogg to be modified. 2. later directory reading will fail Actual Results: Couldn't scan directory '.': Operation not permitted Expected Results: Process should continue Problem is here from a while and not new to 0.37. Googling shows that this problem has been fixed for instance on Debian (with misc. other changes) (http://bugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=375110)
Created attachment 137474 [details, diff] Set errno to 0 prior call to readdir Fix the reported bug (against vorbisgain 0.37)
Created attachment 137476 [details, diff] Use mkstemp instead of mktemp While compiling vorbisgain, mktemp warning rose. This patch fixes this issue (but is not mandatory for reported bug)
Created attachment 137478 [details, diff] Fix isatty warning While compiling vorbisgain, warning about implicit declaration for isatty rose. This patch fixes this issue (and is not mandatory for reported bug).
Maybe authors/maintainers could be contacted (i don't know if debian mainteners did), but website (http://sjeng.org/vorbisgain.html) doesn't show lately activity: latest mentionned version is 0.36 while site (on ftp/vorbis) shows a 0.37 that is currently used. According to README authors/maintainers are: Magnus Holmgren <lear@algonet.se> and/or Gian-Carlo Pascutto <gcp@sjeng.org>
This bug has been closed for NEEDINFO. I re-open it with some more. I don't know what info exactly i need to provide. Should the following be not enough please tell me what i must add. Ok, maybe i should have said that impacted version of vorbisgain is at least 0.37 (but i suspect that this bug has been there for a while (debian fixed this in 0.36)), and all linux and bsd versions are impacted (even other non-windows OSes). And here is my emerge --info: Portage 2.1.4_rc4 (default-linux/amd64/2006.0, gcc-4.1.2, glibc-2.7-r0, 2.6.23-gentoo-r2cyann x86_64) ================================================================= System uname: 2.6.23-gentoo-r2cyann x86_64 AMD Sempron(tm) Processor 3000+ Timestamp of tree: Sat, 01 Dec 2007 00:16:01 +0000 app-shells/bash: 3.2_p17-r1 dev-java/java-config: 1.3.7, 2.1.3 dev-lang/python: 2.4.4-r4, 2.5.1-r4 dev-python/pycrypto: 2.0.1-r6 sys-apps/baselayout: 1.12.10-r5 sys-apps/sandbox: 1.2.18.1-r2 sys-devel/autoconf: 2.13, 2.61-r1 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10 sys-devel/binutils: 2.18-r1 sys-devel/gcc-config: 1.4.0-r4 sys-devel/libtool: 1.5.24 virtual/os-headers: 2.6.23-r2 ACCEPT_KEYWORDS="amd64 ~amd64" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=k8 -O2 -pipe -Wall" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/config /var/bind" CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d" CXXFLAGS="-march=k8 -O2 -pipe -Wall" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig candy distlocks metadata-transfer moo sandbox sfperms strict unmerge-orphans userfetch" GENTOO_MIRRORS="http://mirror.switch.ch/mirror/gentoo/" LANG="en_US" LC_ALL="en_US" LINGUAS="en_GB en_US en fr fr_FR" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/portage/local/layman/pro-audio /usr/portage/local/layman/miro-overlay /usr/local/portage" SYNC="rsync://rsync.fr.gentoo.org/gentoo-portage" USE="X a52 aac aalib alsa amd64 bash-completion berkdb bitmap-fonts bzip2 cairo cdparanoia cli colordiff cracklib crypt cscope cups curl d dga directfb dri dvd dvdread emboss encode exif fbdev firefox flac foomaticdb fortran gif glitz gnome gphoto2 gpm gstreamer gtk gtk2 hal iconv imlib ipv6 isdnlog jack jpeg kde ladspa libcaca lm_sensors lzw lzw-tiff mad matroska midi mp3 mpeg msn mudflap multiuser ncurses nethack nls nptl nptlonly nsplugin objc ogg oggvorbis opengl openmp pam pcre pdf perl png pppd python qt3 qt4 quicktime readline reflection sdl sensord session spell spl ssl svg tcpd theora threads tiff truetype truetype-fonts type1-fonts unicode usb userlocales vorbis wifi wxwindows x264 xorg xpm xv xvid xvmc zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="canon ptp2" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en_GB en_US en fr fr_FR" USERLAND="GNU" VIDEO_CARDS="vesa vga via fbdev" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
fixed with 0.37-r1, thanks for reporting
