Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 200608 - [PATCH] media-tv/linuxtv-dvb-apps-1.1.1.20071126 fails to compile on uclibc due to unimplemented AI_ADDRCONFIG
Summary: [PATCH] media-tv/linuxtv-dvb-apps-1.1.1.20071126 fails to compile on uclibc d...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Television related Applications in Gentoo's Portage
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-28 07:57 UTC by Natanael Copa
Modified: 2007-12-01 21:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
linuxtv-dvb-apps-ai_addrconfig.patch (linuxtv-dvb-apps-ai_addrconfig.patch,509 bytes, patch)
2007-11-28 07:58 UTC, Natanael Copa
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Natanael Copa 2007-11-28 07:57:08 UTC
...
CC gnutv
gnutv.c: In function `main':
gnutv.c:245: error: `AI_ADDRCONFIG' undeclared (first use in this function)
gnutv.c:245: error: (Each undeclared identifier is reported only once
gnutv.c:245: error: for each function it appears in.)
make[2]: *** [gnutv] Error 1

Its completely safe to just remove the AI_ADDRCONFIG flag since you need to check if socket is successfully created anyway. Worst case effect is you get error message "Faild to create socket" (gnutv_data.c:126) rather than "Failed to resolve address" (gnutv.c:248).
Comment 1 Natanael Copa 2007-11-28 07:58:18 UTC
Created attachment 137202 [details, diff]
linuxtv-dvb-apps-ai_addrconfig.patch

while I was there i also set .ai_family = AF_UNSPEC which is the recommended way according the getaddrinfo man page. (I suspect AF_UNSPEC == 0 so it doesn't really make any difference in real life).
Comment 2 solar (RETIRED) gentoo-dev 2007-11-28 15:15:02 UTC
This patch is logical. Reassigning to maintainers for cvs commit. ncopa can 
you also send this patch upstream and explain why they should not be using 
that define.. thanks in advance.
Comment 3 Natanael Copa 2007-11-29 10:59:01 UTC
(In reply to comment #2)
> This patch is logical. Reassigning to maintainers for cvs commit. ncopa can 
> you also send this patch upstream and explain why they should not be using 
> that define.. thanks in advance.
> 

patch sent upstream.
Comment 4 Matthias Schwarzott gentoo-dev 2007-12-01 21:41:22 UTC
Added a new snapshot (linuxtv-dvb-apps-1.1.1.20071201) that already contains this change.