Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 200495 - repoman fails to detect quoting issues on continued line
Summary: repoman fails to detect quoting issues on continued line
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-27 09:32 UTC by Matthias Schwarzott
Modified: 2012-12-24 22:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Schwarzott gentoo-dev 2007-11-27 09:32:43 UTC
While correcting quoting of linuxtv-dvb-apps I found a case where repoman (portage-2.1.4_rc3) failed to detect an issue.

Part of ebuild:
emake bindir=/usr/bin datadir=/usr/share libdir=/usr/$(get_libdir) \
prefix=/usr DESTDIR=${D} INSTDIR=${T} install || die "install failed"

No warning is displayed.
Comment 1 Zac Medico gentoo-dev 2007-11-27 20:15:56 UTC
The EbuildQuote check currently doesn't track state across line continuations. We want to try not to generate false positives for variable assignments that don't need quoting, like this line by itself does not require quoting if it is just variable assignments rather than command arguments:

DESTDIR=${D} INSTDIR=${T}
Comment 2 SpanKY gentoo-dev 2007-11-28 10:09:27 UTC
with line continuations, i dont think we'd get any more false positives by collapsing the lines

so we'd take:
foo \
moo \
boo

collapse it down to:
foo moo boo

and then feed it to the checker