Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 200055 - rox-base/tasktray-0.5.3 incompatible with gnome-python-desktop-2.20.0
Summary: rox-base/tasktray-0.5.3 incompatible with gnome-python-desktop-2.20.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Rox Herd (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-23 08:55 UTC by Bernard Fortz
Modified: 2007-11-26 13:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Fixed /usr/lib/rox/TaskTray/AppletRun (AppletRun,24.47 KB, text/plain)
2007-11-23 08:57 UTC, Bernard Fortz
Details
Second version (AppletRun,24.47 KB, text/plain)
2007-11-23 12:16 UTC, Bernard Fortz
Details
Third version (AppletRun,24.48 KB, text/plain)
2007-11-25 18:53 UTC, Bernard Fortz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bernard Fortz 2007-11-23 08:55:51 UTC
The callback function active_window_changed() was called with one argument in gnome-python-desktop <= 2.18, now it calls with two arguments, which makes the rox-tasktray unusable.

Reproducible: Always

Steps to Reproduce:
1. launch rox-tasktray ! 


Actual Results:  
Error box displayed continously


Fixed it locally by adding a dummy argument to active_window_changed()
Comment 1 Bernard Fortz 2007-11-23 08:57:32 UTC
Created attachment 136742 [details]
Fixed /usr/lib/rox/TaskTray/AppletRun

Here is my modified version of /usr/lib/rox/TaskTray/AppletRun that fixes the bug
Comment 2 Bernard Fortz 2007-11-23 12:16:19 UTC
Created attachment 136759 [details]
Second version

Updated to fix active_workspace_changed
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-11-23 16:24:45 UTC
Don't resolve bugs unfixed anywhere.
Comment 4 Bernard Fortz 2007-11-25 18:53:10 UTC
Created attachment 136997 [details]
Third version

Fixes the case of a window moved across workspaces
Comment 5 Jim Ramsay (lack) (RETIRED) gentoo-dev 2007-11-26 13:11:58 UTC
Thanks for the heads-up here, I haven't done a large update in a while (still at 2.18 with gnome-python-desktop and libwnck)

For future reference, changes should preferably be backwards-compatible (your change breaks if I still have gnome-python-desktop-2.18 installed), and I prefer a patch (diff -u) instead of a complete file.

But good work, my actual fix is based on your changes.  Basically I just added '=None' to your dummy arguments in the function definitions so they'll still work if only called with 1 arg :)

I've also submitted this upstream, but I think that the newest version (0.6.3) is not affected by this bug anyway.  I'll probably be adding it soon, but there's a new library dependency I need to take care of for the new version first.

Committed as rox-base/tasktray-0.5.3-r1