Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199963 - easytag-2.1.3 .desktop file fixes for Comment[ru] and icon.
Summary: easytag-2.1.3 .desktop file fixes for Comment[ru] and icon.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-22 10:55 UTC by Peter Volkov (RETIRED)
Modified: 2007-11-22 12:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
easytag-2.1.3-.desktop-fixes.patch (easytag-2.1.3-.desktop-fixes.patch,1.80 KB, patch)
2007-11-22 10:55 UTC, Peter Volkov (RETIRED)
Details | Diff
easytag-2.1.3-r1.ebuild.patch (easytag-2.1.3-r1.ebuild.patch,1.05 KB, patch)
2007-11-22 10:57 UTC, Peter Volkov (RETIRED)
Details | Diff
easytag-2.1.3-r1.ebuild.patch (easytag-2.1.3-r1.ebuild.patch,795 bytes, patch)
2007-11-22 11:07 UTC, Peter Volkov (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2007-11-22 10:55:00 UTC
easytag-2.1.3 has broken .desktop file. It contains junk in Comment[ru] and icon name is wrong. Junk was recovered with the following command:
grep 'Comment[ru]' /usr/share/applications/easytag.desktop | iconv -f utf-8 -t koi8-r | iconv -f cp1251

Also I think we do not need to install ChangeLog in /usr/share/easytag. archived copy of ChangeLog resides in /usr/share/doc.

Fixes follow.
Comment 1 Peter Volkov (RETIRED) gentoo-dev 2007-11-22 10:55:43 UTC
Created attachment 136668 [details, diff]
easytag-2.1.3-.desktop-fixes.patch

Patch for .desktop file.
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2007-11-22 10:57:24 UTC
Created attachment 136669 [details, diff]
easytag-2.1.3-r1.ebuild.patch

Patch to fix unnecessary ChangeLog installation and to apply .desktop file fixes.
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2007-11-22 10:58:58 UTC
Forgot to notices that all above was sent upstream and I hope will be included in next version. As soon as I receive any reaction from upstream I'll add a note here.
Comment 4 Peter Volkov (RETIRED) gentoo-dev 2007-11-22 11:07:07 UTC
Created attachment 136670 [details, diff]
easytag-2.1.3-r1.ebuild.patch

Sorry. ChangeLog is required as it's shown in the about dialog... New patch for ebuild is applied.
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2007-11-22 12:12:44 UTC
Thanks for the [ru] update, but

+Icon=EasyTAG_icon.xpm

is wrong. Icon= cannot end with an extension if it's not a Full Path according to f.d.o spec.

I've patched the .desktop file myself when 2.1.3 was released and contacted upstream about the changes, it fixes the Icon= entry and removes the Encoding= entry as it's deprecated.

I was just lazy to add it into tree, and was waiting for 2.1.4.. :-)
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2007-11-22 12:13:17 UTC
Check out command "desktop-file-validate" from desktop-file-utils.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2007-11-22 12:15:42 UTC
and Application entry in Categories is also deprecated, plus X-Desktop-File-Install-Version= should reflect entry spec version number which would be after changes 1.0
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2007-11-22 12:18:13 UTC
(In reply to comment #7)
> would be after changes 1.0

Hmm or 0.14 to reflect desktop-file-utils versioning.. need to check
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2007-11-22 12:26:52 UTC
fixed in cvs, thanks