Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199830 - adbhid driver and caps lock behaviour issues
Summary: adbhid driver and caps lock behaviour issues
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: PPC Linux
: High enhancement
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: http://lkml.org/lkml/2007/7/13/519
Whiteboard: linux-2.6.24
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-20 21:27 UTC by Patrick Goldmann
Modified: 2008-02-07 12:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch to drivers/macintosh/adbhid.c (adbhid-caps.patch,2.48 KB, patch)
2007-11-20 21:36 UTC, Patrick Goldmann
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Goldmann 2007-11-20 21:27:33 UTC
This patch enables ppc users with ADB keyboards to use caps lock as control key.
Behaviour is off by default, so it should be non-breaking for everyone else.

Reproducible: Always

Steps to Reproduce:
1. Remap caps lock to control (eg using xmodmap, xorg.conf options, ...)

Actual Results:  
As the current code in adbhid.c seems to generate keypress/keyrelease events immediately even if caps lock is still pressed, remapping results in a non-functional caps lock key

Expected Results:  
caps lock should be able to act as control ;)

Additional information is available at Andrew McNabb's post to LKML
Comment 1 Patrick Goldmann 2007-11-20 21:31:46 UTC
Forgot to add:
this patch applies cleanly to gentoo-sources-2.6.23-r2
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-11-20 21:32:21 UTC
Get this accepted upstream please...

http://dev.gentoo.org/~dsd/genpatches/faq.htm
Comment 3 Patrick Goldmann 2007-11-20 21:36:52 UTC
Created attachment 136547 [details, diff]
proposed patch to drivers/macintosh/adbhid.c
Comment 4 Patrick Goldmann 2007-11-20 21:40:46 UTC
apparently nobody cares upstream, since Andrew McNabb posted this back in July.
i'm just sick of patching the kernel manually, and to me it seems this shouldn't create problems as it's off by default. so why don't include it into the gentoo patchset?
Comment 5 Mike Pagano gentoo-dev 2008-01-18 23:04:00 UTC
Can you please test vanilla-sources-2.6.24_rc8.  This commit might be relevant:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f31c05ea0f5690d002ae30710fc0fbe0f0c201f

Comment 6 Daniel Drake (RETIRED) gentoo-dev 2008-01-19 11:59:03 UTC
that patch seems to suggest that the patch posted on this bug (that adds restore_capslock_events) has also been merged, so this should just be a case of adding both upstream patches to our kernel
Comment 7 Mike Pagano gentoo-dev 2008-01-21 15:23:55 UTC
(In reply to comment #6)
> that patch seems to suggest that the patch posted on this bug (that adds
> restore_capslock_events) has also been merged, so this should just be a case of
> adding both upstream patches to our kernel

Agreed. And here's a link to the first patch to make our lives easier once we get confirmation that the problem is solved in 2.6.24_rc8

Comment 9 Mike Pagano gentoo-dev 2008-01-29 13:07:49 UTC
Please test with gentoo-sources-2.6.24 and report the results back here. Thanks.
Comment 10 Daniel Drake (RETIRED) gentoo-dev 2008-02-07 12:21:47 UTC
This should be fixed in 2.6.24, please reopen if not. Given that it's a low priority feature and we're actively working on 2.6.24, I don't plan to backport it to 2.6.23.