Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199696 - media-fonts/terminus-font - optional patches
Summary: media-fonts/terminus-font - optional patches
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Fonts Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-19 20:10 UTC by Kir Kolyshkin
Modified: 2008-06-21 09:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
version of media-fonts/terminus-font including all possible patches from author (terminus-font-4.20.ebuild,2.18 KB, text/plain)
2008-02-03 20:02 UTC, Leonid Evdokimov
Details
patch for terminus-font-4.26.ebuild (terminus-font-4.26.patch,2.12 KB, patch)
2008-06-20 16:05 UTC, Leonid Evdokimov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kir Kolyshkin 2007-11-19 20:10:37 UTC
On a terminus font home page (http://www.is-vn.bg/hamster/jimmy-en.html) there is a number of patches available. Those patches alter some glyphs in this or that way (as shown on the page).

I do like to use some (but not all!) of them as it makes specific Cyrillic glyphs looks better. Could it be possible to modify the ebuild so that one could specify which specific patches one wants to be applied using USE flags?

So far this is what I've done -- and yes, while it's fine for me I do understand that different users needs different things, thus the request.

--- /usr/portage/media-fonts/terminus-font/terminus-font-4.20.ebuild    2007-09-16 08:07:37.000000000 +0400
+++ /usr/local/portage/media-fonts/terminus-font/terminus-font-4.20.ebuild     2007-11-19 05:03:34.000000000 +0300
@@ -2,6 +2,8 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/media-fonts/terminus-font/terminus-font-4.20.ebuild,v 1.13 2007/09/16 04:01:46 dirtyepic Exp $
 
+inherit eutils
+
 DESCRIPTION="A clean fixed font for the console and X11"
 HOMEPAGE="http://www.is-vn.bg/hamster/jimmy-en.html"
 SRC_URI="http://www.is-vn.bg/hamster/${P}.tar.gz"
@@ -13,6 +15,16 @@
 DEPEND="X? ( x11-apps/bdftopcf )"
 RDEPEND=""
 
+src_unpack() {
+       local f
+       unpack ${A}
+
+       cd "${S}"
+       for f in dv1 ge1 gq2 ij1; do
+               epatch "${FILESDIR}"/${P}-$f.diff.gz
+       done
+}
+
 src_compile() {
        ./configure \
                --prefix=/usr \


Reproducible: Always
Comment 1 Leonid Evdokimov 2008-02-03 20:02:06 UTC
Created attachment 142601 [details]
version of media-fonts/terminus-font including all possible patches from author

I think, USE flags should be renamed to something better, but I have no idea.
Comment 2 Leonid Evdokimov 2008-06-15 12:56:58 UTC
Is there anything wrong with the patch?
Comment 3 Leonid Evdokimov 2008-06-20 16:05:58 UTC
Created attachment 157797 [details, diff]
patch for terminus-font-4.26.ebuild
Comment 4 Peter Volkov (RETIRED) gentoo-dev 2008-06-21 09:26:27 UTC
Thank you for report Kir and for your work Leonid. Fixed in terminus-font-4.26-r1.

Leonid I've named a bit differently USE flags. I think my use flags are more self descriptive then yours also I've changed a bit description but preserved your descriptions in ebuild itself. The should go in metadata.xml later. If you have any comment on USE flags names or descriptions, please, speak now! :)

Also epatch dies by itself so you don't need to do things like this:

use dv && { epatch "${FILESDIR}/${P}-dv1.diff.gz" || die "epatch failed"; }

it should be just 

use dv && epatch "${FILESDIR}/${P}-dv1.diff.gz"

Have a good time.