Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 199626 - media-video/jubler-3.4.0 (version bump)
Summary: media-video/jubler-3.4.0 (version bump)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL: http://www.jubler.org
Whiteboard:
Keywords: EBUILD, InOverlay
Depends on:
Blocks:
 
Reported: 2007-11-19 04:22 UTC by Serkan Kaba (RETIRED)
Modified: 2007-11-21 22:09 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Serkan Kaba (RETIRED) gentoo-dev 2007-11-19 04:22:16 UTC
Ebuild for the new version
http://overlays.gentoo.org/proj/java/browser/java-experimental/media-video/jubler
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2007-11-20 14:23:36 UTC
I wonder if GNOME is also able to use these files:
use kde && doins resources/installers/linux/sub-*.desktop

Any way these desktop files are in a deprecated format. We should submit a patch to upstream so that they use the new spec:

http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#deprecated-items
http://www.freedesktop.org/wiki/Specifications/AddingMIMETutor
Comment 2 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 02:07:48 UTC
Ok. I got the ebuild working using shared-mime-info specification. Now just make sure it works in KDE too and we are all set.
Comment 3 Serkan Kaba (RETIRED) gentoo-dev 2007-11-21 04:16:25 UTC
changed icon installation dir to gnome instead of hicolor
Comment 4 Serkan Kaba (RETIRED) gentoo-dev 2007-11-21 04:24:23 UTC
srt is still not working and I guess its because its defined in fd.org's xml file.
using shared-mime-info-0.22-r1
Comment 5 Serkan Kaba (RETIRED) gentoo-dev 2007-11-21 04:34:52 UTC
(In reply to comment #4)
> srt is still not working and I guess its because its defined in fd.org's xml
> file.
> using shared-mime-info-0.22-r1
> 

fixed that also
Comment 6 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 11:50:48 UTC
(In reply to comment #3)
> changed icon installation dir to gnome instead of hicolor
> 

That's wrong. hicolor is a fallback icon theme that should be always searched if the in use theme doesn't have the icon you are looking for. If you install to gnome then it won't be used in for example XFCE.

http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout
Comment 7 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 13:13:51 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > srt is still not working and I guess its because its defined in fd.org's xml
> > file.
> > using shared-mime-info-0.22-r1
> > 
> 
> fixed that also
> 

I added support for KDE to the ebuild. The version you committed also had a buggy mime xml (it's not even valid) so I think that might be why it wasn't working for you.
Comment 8 Serkan Kaba (RETIRED) gentoo-dev 2007-11-21 15:03:20 UTC
(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > srt is still not working and I guess its because its defined in fd.org's xml
> > > file.
> > > using shared-mime-info-0.22-r1
> > > 
> > 
> > fixed that also
> > 
> 
> I added support for KDE to the ebuild. The version you committed also had a
> buggy mime xml (it's not even valid) so I think that might be why it wasn't
> working for you.
> 

2 questions about final state of the ebuild.
* Shouldnt KDE installation depend on kde USE flag?
* Shouldnt kde association desktop files be renamed to x-{type}.desktop?
Comment 9 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 20:52:19 UTC
(In reply to comment #8)
> 
> 2 questions about final state of the ebuild.
> * Shouldnt KDE installation depend on kde USE flag?
> * Shouldnt kde association desktop files be renamed to x-{type}.desktop?
> 

They should yes but the name of the file does not matter as the mime type name is inside the file itself.
Comment 10 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 20:53:34 UTC
(In reply to comment #8)
> 
> 2 questions about final state of the ebuild.
> * Shouldnt KDE installation depend on kde USE flag?
> * Shouldnt kde association desktop files be renamed to x-{type}.desktop?
> 

And for the first item there is really not much harm in always installing them. IMHO it's better that way than having to recompile a bunch of thins just for a couple of .desktop files. If you don't want that directory, then you can use INSTALL_MASK.
Comment 11 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 21:00:52 UTC
(In reply to comment #9)
> 
> They should yes but the name of the file does not matter as the mime type name
> is inside the file itself.
> 

I should have added that the reason I did not do this is to make clearer patch.
Comment 12 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 21:11:42 UTC
Version bump committed.
Comment 13 Petteri Räty (RETIRED) gentoo-dev 2007-11-21 22:09:07 UTC
I posted the patch to jubler upstream http://jubler.org/smf/index.php/topic,88.0.html