Bug 198856 – x11-themes/gnome-icon-theme-2.20.0: patch for using crystalsvg icon theme when needed

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Pacho Ramos 2007-11-11 20:12:12 UTC]

Some apps like Education menu category, kooka, QT Designer, QT Assistant... don't have an icon in gnome-icon-theme or hicolor icon theme. 

The attached patch simply adds the following line to index.theme:
Inherits=hicolor,crystalsvg

This way, gnome-icon-theme will use crystalsvg if it cannot find the icon in itself or hicolor. I add "hicolor" before "crystalsvg" because, if I only add crystalsvg, gnome-icon-them would use crystalsvg instead of hicolor icons if the icon is missing from gnome-icon-theme

With the patch, gnome-icon-theme will try to use:
1º Its own icon if available
2º hicolor icon if available
3º crystalsvg if available  
4º no icon will shown if it cannot find the icon

Without the patch (current behavior) it uses:
1º Its icon if available
2º hicolor icon if available
3º Nothing

This patch doesn't add a dependency on crystalsvg theme, because it will only be used if it's present, also, it will be present when most of affected apps are installed

Thanks a lot


Reproducible: Always

[Comment 1 Pacho Ramos 2007-11-11 20:12:35 UTC]

Created attachment 135763 [details, diff]
gnome-icon-theme-2.20.0-crystalsvg.patch

[Comment 2 Jakub Moc (RETIRED) 2007-11-11 21:45:31 UTC]

Submit this upstream, please.

http://bugzilla.gnome.org/

[Comment 3 Gilles Dartiguelongue (RETIRED) 2008-04-07 08:26:42 UTC]

waiting for upstream information.

[Comment 4 Pacho Ramos 2008-04-07 19:09:11 UTC]

(In reply to comment #3)
> waiting for upstream information.
> 

Sorry I forgot this

Upstream rejected it because they would prefer use hicolor icon theme when needed. I think that would be easier simply patch gnome-icon-theme for using crystalsvg instead of duplicate icons in crystalsvg and hicolor.

What do you think? I can also go to "hicolor way" and send proper fixes for each affected app I find if you prefer it

Thanks

[Comment 5 Gilles Dartiguelongue (RETIRED) 2008-04-12 14:32:55 UTC]

I'm not sure to understand the problem here but since upstream just rejected the patch, I'm not inclined to include it. If someone can get it to be in a shape that upstream would accept they we can reconsider.

[Comment 6 Pacho Ramos 2008-04-12 15:27:59 UTC]

(In reply to comment #5)
> I'm not sure to understand the problem here but since upstream just rejected
> the patch, I'm not inclined to include it. If someone can get it to be in a
> shape that upstream would accept they we can reconsider.
> 

I will try to send some bugs for installing affected icons in hicolor them for fixing this.

You can see the problem, for example, if you have qt4 installed, you will see that no icon is shown in qtdesigner, assistant and linguist menu entries. Same occurs with kooka menu entry