There were 2 main problems with the mgetty-1.1.26-r2.ebuild which I have fixed in this updated ebuild. #1) The src_unpack function used sed to edit policy.h to correct the logfile define for the mgetty.% log, however there is also a sendfax log which should also be changed. I updated the sed code to edit both logfile locations. I also added another sed command to uncomment the CNDFILE define in policy.h. This activates Calling Number Display (CND) options. With this undefined (as shipped), mgetty will never read the "dialin.config" config file and CND processing is disabled. Activating CND is benign since there are no definitions in the example dialin.config, it will have no effect. I have had CND working in mgetty (non- gentoo) for over a year with no problems. #2 The make (emake) statements in src_compile did not pass some needed variables to make. At compile time, mgetty uses ${prefix} and $CONFDIR (among others) in #defines inside several source files. Leaving these to the default values would cause mgetty to have incorect paths hardcoded internally and could lead to problems at run time. The Makefile also has CFLAGS set internally which override the users chosen flags (in make.conf) I corrected both of these problems by passing the appropriate environment variables to both the main mgetty make and the make for the voice utils. mgetty now compiles with correct internal paths, and the users chosen CFLAGS. Feel free to leave out the CND stuff if you want (though I can see no reason to) simply delete the entire 3rd line in the sed command (ie the 3rd -e line containing "CNDFILE") I thought of making it optional but couldnt think how to without another USE variable which I thought was overkill.
Created attachment 632 [details] mgetty-1.1.26-r3.ebuild (Updated ebuild)
Noticed another bug in this ebuild - in src_install, INFODIR=${D}/usr/share should read INFODIR=${D}/usr/share/info Tried to upload a revised ebuild but it didnt work. Can you fix this one by hand, thanks.
committed.
