Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 198438 - app-editors/emacs-22.1-r1: flyspell-mode fails with aspell (patch enclosed)
Summary: app-editors/emacs-22.1-r1: flyspell-mode fails with aspell (patch enclosed)
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Emacs project
URL: http://homes.esat.kuleuven.be/~sseys/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-08 09:44 UTC by Jakob Schiotz
Modified: 2007-11-08 13:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to app-editors/emacs-22.1-r1 (flyspell-bug.patch,419 bytes, patch)
2007-11-08 09:46 UTC, Jakob Schiotz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Schiotz 2007-11-08 09:44:29 UTC
Flyspell-mode does not work if you use aspell instead of ispell, due to a change in a command line option in later versions of aspell.

I have enclosed a patch to fix it.  I do not know if it will cause problems with older versions of aspell.

Reproducible: Always

Steps to Reproduce:
1. Have emacs and aspell (not ispell) installed.  Tell emacs to use aspell with the command (setq-default ispell-program-name "aspell") in .emacs
2. Start emacs, editing a text file
3. Run the command flyspell-buffer

Actual Results:  
The error message "cannot check region"

Expected Results:  
Spell checking of the buffer.


demokrit textmodes # emerge --info
Portage 2.1.3.16 (default-linux/amd64/2006.1, gcc-4.1.2, glibc-2.6.1-r0, 2.6.22-gentoo-r9 x86_64)
=================================================================
System uname: 2.6.22-gentoo-r9 x86_64 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz
Timestamp of tree: Mon, 05 Nov 2007 08:20:01 +0000
app-shells/bash:     3.2_p17
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.4.4-r5
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.9-r2
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.3.16
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=nocona"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe -march=nocona"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer parallel-fetch sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://mirror.uni-c.dk/pub/gentoo/ http://pandemonium.tiscali.de/pub/gentoo/ http://ftp.linux.ee/pub/gentoo/distfiles/ http://trumpetti.atm.tut.fi/gentoo/"
LANG="en_US.UTF8"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage /home/schiotz/development/CamposEbuilds/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X acpi alsa amd64 asf atlas berkdb bitmap-fonts bzip2 cddb cdparanoia cdr cli cracklib crypt cups dri dvd dvdr dvdread emacs encode firefox foomaticdb fortran gcj gd gdbm gif gimp gpm gs iconv idn imagemagick imap isdnlog java jbig jpeg jpeg2k kdeenablefinal kdexdeltas maildir mbox midi mime mmap mp3 mpeg mudflap ncurses netcdf nls nptl nptlonly ogg opengl openmp pam pcmcia pcre pdf perl png ppds pppd python qt3 quicktime readline reflection scanner session smp spell spl ssl tcpd tetex tiff tk truetype-fonts type1-fonts unicode usb vcd wxwindows xine xorg xv xvid xvmc zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" USERLAND="GNU" VIDEO_CARDS="radeon vesa fbdev"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LDFLAGS, LINGUAS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Jakob Schiotz 2007-11-08 09:46:22 UTC
Created attachment 135477 [details, diff]
Patch to app-editors/emacs-22.1-r1

This patch fixes the bug, as described on the web page in the URL field.
Comment 2 Ulrich Müller gentoo-dev 2007-11-08 10:24:02 UTC
Could you please provide us with the following information:
1. Output of "M-x ispell-check-version"
2. Value of variable ispell-really-aspell ("C-h v ispell-really-aspell")

-		    (if ispell-really-aspell "list" "-l")
+		    (if ispell-really-aspell "list" "-list")

This would affect the "else" clause, i.e. the non-aspell case.
Comment 3 Jakob Schiotz 2007-11-08 11:15:43 UTC
(In reply to comment #2)
> Could you please provide us with the following information:
> 1. Output of "M-x ispell-check-version"

@(#) International Ispell Version 3.1.20 (but really Aspell 0.60.5), ispell.el 3.6 - 7-Jan-2003

> 2. Value of variable ispell-really-aspell ("C-h v ispell-really-aspell")

ispell-really-aspell is a variable defined in `ispell.el'.
Its value is t


Documentation:
Not documented as a variable.
> 
> -                   (if ispell-really-aspell "list" "-l")
> +                   (if ispell-really-aspell "list" "-list")
> 
> This would affect the "else" clause, i.e. the non-aspell case.
> 

I hope this helps!  I took the change from the web pages mentioned without understanding it 100%, but I must admit it looks a bit strange.  Nevertheless, the fix works for me.


/Jakob



Comment 4 Jakob Schiotz 2007-11-08 11:27:04 UTC
Weird, returning to the original version does NOT make the problem return.  It is really strange (and I have not dreamt up the problem, it has bothered me for at least a month).  The only thing that is not exactly as before is the flyspell.elc file, since I recreate it every time I changed the .el file, it could have been corrupted as originally installed.

I have the same problem on another computer, where emacs has not been updated to version 22.  I am currently upgrading it, and will test the problem again including the variable you ask for.

/Jakob
Comment 5 Jakob Schiotz 2007-11-08 11:59:12 UTC
Ooops mea culpa!

The bug is only in emacs 21, I had not realised that when I upgraded to version 22, it was a slotted install, and version 21 was still the default.  When I looked for flyspell.el to try out the fix, I noticed two versions and removed version 21, this happened at the same time as applying this fix.

Since the bug is gone in version 22, I close this bug as invalid, and apologize for wasting your time!

/Jakob
Comment 6 Ulrich Müller gentoo-dev 2007-11-08 13:43:32 UTC
(In reply to comment #5)
> I had not realised that when I upgraded to version 22, it was a slotted
> install, and version 21 was still the default.

That's why it is useful to read the postinst elog messages where we explain this. ;-)

> [...] and apologize for wasting your time!

Never mind. Some percentage of invalid bugs is much better than bugs that are noticed by users, but not reported to us.