Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 198222 - mail-mta/qmail-ldap doesn't honor USE="-controldb"
Summary: mail-mta/qmail-ldap doesn't honor USE="-controldb"
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Benedikt Böhm (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-06 00:43 UTC by Brian Moon
Modified: 2007-11-06 08:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
07123 (07123.html,67.37 KB, text/html)
2007-11-06 01:17 UTC, Ybien Ksor
Details
07226 (07226.html,64.86 KB, text/html)
2007-11-06 01:20 UTC, Ybien Ksor
Details
07363 (07363.html,64.99 KB, text/html)
2007-11-06 01:22 UTC, Ybien Ksor
Details
07422 (07422.html,65.79 KB, text/html)
2007-11-06 01:23 UTC, Ybien Ksor
Details
07595 (07595.html,61.42 KB, text/plain)
2007-11-06 01:23 UTC, Ybien Ksor
Details
07632 (07632.html,58.46 KB, text/plain)
2007-11-06 01:23 UTC, Ybien Ksor
Details
07714 (07714.html,68.81 KB, text/plain)
2007-11-06 01:24 UTC, Ybien Ksor
Details
07845 (07845.html,60.29 KB, text/html)
2007-11-06 01:24 UTC, Ybien Ksor
Details
07971 (07971.html,61.18 KB, text/html)
2007-11-06 01:25 UTC, Ybien Ksor
Details
08096 (08096.html,69.17 KB, text/html)
2007-11-06 01:25 UTC, Ybien Ksor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Moon 2007-11-06 00:43:46 UTC
The qmail-ldap package is supposed to allow one to skip the controldb patch.  However, even with it off, controldb is included.

Reproducible: Always

Steps to Reproduce:
# emerge -v qmail-ldap

Actual Results:  
controldb is included

Expected Results:  
controldb should not be included

Here is a -pv output:


# emerge -pv qmail-ldap

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild   R   ] mail-mta/qmail-ldap-1.03-r7  USE="qmail-spp ssl zlib -cluster -controldb -debug -gencertdaily -highvolume -mailwrapper -rfc2307 -rfc822" 0 kB 

Total: 1 package (1 reinstall), Size of downloads: 0 kB


When removing -p you see in the output this information:

>>> Unpacking qmail-1.03.tar.gz to /var/tmp/portage/mail-mta/qmail-ldap-1.03-r7/work
* Applying qmail-ldap-1.03-20060201.patch.gz ...
 [ ok ]
* Applying qmail-ldap-1.03-20060201-controls20060401d.patch ... [ ok ] <----- wrong
* Applying qmail-ldap-1.03-queue-custom-error.patch ...
 [ ok ]
* Applying qmail-ldap-1.03-spp-0.42.patch ...
 [ ok ]


And you see this:

/compile -DALTQUEUE -DEXTERNAL_TODO -DDASH_EXT -DSMTPEXECCHECK -DDATA_COMPRESS -D QMQP_COMPRESS  -DUSE_CONTROLDB -DQLDAP_BAILOUT  -DSECUREBIND_TLS -
DSECUREBIND_SSL -DTLS_REMOTE -DTLS_SMTPD -I/usr/include  \
       qmail-smtpd.c

-DUSE_CONTROLDB is the bad part there.
Comment 1 Brian Moon 2007-11-06 01:02:49 UTC
It looks like line 76:

epatch ${DISTDIR}/${P}-${QMAIL_LDAP_PATCH}-controls${CONTROLS_PATCH}.patch

just needs a use controldb && on it:

use controldb && sed -i -e 's|NEWLDAPPROGLIBS=.*|& str.a|' Makefile

Same for line 79.

The flag is checked on line 290 when the LDAP schema is installed.  Just not when applying the patches.
Comment 2 Ybien Ksor 2007-11-06 01:17:48 UTC
Created attachment 135288 [details]
07123
Comment 3 Ybien Ksor 2007-11-06 01:20:09 UTC
Created attachment 135290 [details]
07226
Comment 4 Ybien Ksor 2007-11-06 01:22:36 UTC
Created attachment 135292 [details]
07363
Comment 5 Ybien Ksor 2007-11-06 01:23:05 UTC
Created attachment 135294 [details]
07422
Comment 6 Ybien Ksor 2007-11-06 01:23:29 UTC
Created attachment 135296 [details]
07595
Comment 7 Ybien Ksor 2007-11-06 01:23:57 UTC
Created attachment 135297 [details]
07632
Comment 8 Ybien Ksor 2007-11-06 01:24:19 UTC
Created attachment 135298 [details]
07714
Comment 9 Ybien Ksor 2007-11-06 01:24:50 UTC
Created attachment 135300 [details]
07845
Comment 10 Ybien Ksor 2007-11-06 01:25:21 UTC
Created attachment 135301 [details]
07971
Comment 11 Ybien Ksor 2007-11-06 01:25:48 UTC
Created attachment 135302 [details]
08096
Comment 12 Benedikt Böhm (RETIRED) gentoo-dev 2007-11-06 08:25:08 UTC
no idea why mr_bones_ added the useflag, but it is bougs. it doesn't work without the controldb patch... but applying that patch does not mean you have to use controldb ...