In my fresh 2007.0 amd64 install there is no "dialog" installed. Just modifying the etc-update.conf (mode=1) leads to permanent error Exiting: User termination! The reason for this is that there is no errorcode checking after the call of "dialog --menu ...", only a minimalistic "exit-on-error" is provided. The patch following this post is introducing a simple check for this: [[ -z $( type -p dialog ) ]] && echo "etc-update: WARNING -- dialog not found, using non-menu mode." && mode=0 The patch http://bugs.gentoo.org/attachment.cgi?id=13668 from Bug#23243 introduces another possibility to catch this. I also introduced "auto merge all" and "discard all" in the dialog execution branches of etc-update. The last change in Bug#23243 in attachment#13668 [details, diff] introduces the viewing of the diff-output within "dialog", including choices. I personally prefer vimdiff, so I did not check the remaining code (check max display size)... Kind regards, Dominik
Created attachment 135113 [details, diff] check for functionality of "dialog" w/switch to text-mode
Created attachment 135121 [details, diff] check dialog functionality on startup and on every use. Also includes choices for "auto merge all" and "remove all updates" as in the text version. Does NOT include modification to show diff-output in a dialog window as proposed in previous bug report (see above).
checking dialog at every step is just silly ive added a check at startup similar to your first patch, thanks
This has been released in 2.1.3.18.
